From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings Date: Mon, 28 Sep 2015 17:10:29 +0800 Message-ID: <20150928091029.GA23312@roam> References: <201509281735.7lYs3Huz%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by alsa0.perex.cz (Postfix) with ESMTP id 72D5C260688 for ; Mon, 28 Sep 2015 11:11:55 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1443417278-19657-2-git-send-email-songjun.wu@atmel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , nicolas.ferre@atmel.com, Liam Girdwood , broonie@kernel.org, kbuild-all@01.org, Songjun Wu , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579 PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Songjun Wu Signed-off-by: Fengguang Wu --- atmel-classd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/atmel/atmel-classd.c +++ b/sound/soc/atmel/atmel-classd.c @@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla dd->gclk = devm_clk_get(dev, "gclk"); if (IS_ERR(dd->aclk)) { - ret = PTR_ERR(dd->gclk); + ret = PTR_ERR(dd->aclk); dev_err(dev, "failed to get GCK clock: %d\n", ret); return ret; }