From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
tiwai@suse.de, Arnaud Pouliquen <arnaud.pouliquen@st.com>,
liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
broonie@kernel.org, Yakir Yang <ykk@rock-chips.com>
Subject: Re: [RFC 0/4] ASoC: Add HDA HDMI codec driver
Date: Fri, 9 Oct 2015 16:28:10 +0100 [thread overview]
Message-ID: <20151009152810.GW32532@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20151009151747.GB3609@vkoul-mobl.iind.intel.com>
On Fri, Oct 09, 2015 at 04:17:48PM +0100, Vinod Koul wrote:
> On Fri, Oct 09, 2015 at 01:52:07PM +0100, Russell King - ARM Linux wrote:
> > On Fri, Oct 09, 2015 at 01:28:45PM +0100, Vinod Koul wrote:
> > > Yes, this patch series attempts to add yet another HDMI driver to
> > > ASoC. This codec appears as HDA codec over HDA link. Although
> > > the codec reside in display we have a HDA link from audio block
> > > to this codec. The communication to codec is over HDA link
> > >
> > > Thanks to i915 component infrastructure, we do not need to worry
> > > about keeping the codec on, this is done by i915 for us.
> > >
> > > Based on discussion with Mark here at ELCE and other attempts by
> > > various folks on HDMI, I wanted to show on list the stuff we have
> > > done and discuss and try to see how we converge various attempts
> > >
> > > The driver here only supports stereo and doesn't do multichannel
> > > just yet, will add later once we converge here. The support for
> > > using i915 component notification by David will be added later
> > > on.
> >
> > I notice that you don't limit the capabilities of the ASoC device to
> > the capabilities of the HDMI sink - is that an intentional design
> > decision, or is it handled some other way?
> >
> > I think that's the "interesting" part of HDMI - how should audio find
> > out the capabilities on the HDMI sink, and that's the area which people
> > have been struggling to design and come to some sort of concensus over.
>
> I think we should set capabilities based on the sink capabilities. And these
> should be set after reading the ELD. We want to do that when stream is
> opened and we query ELD and set the constarinats based on ELD.
> I have not added that code but this was the idea and was planned to come
> after this
Note that there's sound/core/pcm_drm_eld.c which should help you with
that. Please help to improve it if it doesn't meet your needs - it's
a helper precisely to set the constraints based on ELD.
It tries to find the best fit of sample rate vs channels given a ELD
array of SADs.
> So we have discussed this with Takashi and the general idea is that we add a
> SW mechanism as well which will be based on i915 component framework to read
> ELD reliably from display driver
>
> I think as a general idea all the hdmi audio drivers should rely on component
> interface generically to read ELD/ get notification (that was added
> recently). Today on audio we have i915 component interface and IMHO this
> should be made a generic audio-display component interface and used by all.
> The callbacks are not really HDA based. But I don't really know on other
> arch if that is doable or not...
Do you have a pointer to this work?
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-10-09 15:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 12:28 [RFC 0/4] ASoC: Add HDA HDMI codec driver Vinod Koul
2015-10-09 12:28 ` [RFC 1/4] ASoC: hdac-hdmi: Add hdmi driver Vinod Koul
2015-10-09 12:28 ` [RFC 2/4] ASoC: hdac_hdmi: Add PM support for HDMI Vinod Koul
2015-10-09 12:28 ` [RFC 3/4] ASoC: hdac_hdmi: Add hdac hdmi dai ops Vinod Koul
2015-10-09 12:28 ` [RFC 4/4] ASoC: hdac_hdmi: Setup and start infoframe Vinod Koul
2015-10-09 12:49 ` Russell King - ARM Linux
2015-10-09 14:51 ` Vinod Koul
2015-10-09 12:52 ` [RFC 0/4] ASoC: Add HDA HDMI codec driver Russell King - ARM Linux
2015-10-09 15:17 ` Vinod Koul
2015-10-09 15:28 ` Russell King - ARM Linux [this message]
2015-10-09 15:33 ` Vinod Koul
2015-10-13 13:08 ` Koul, Vinod
2015-10-20 0:15 ` Mark Brown
2015-10-20 3:29 ` Vinod Koul
2015-10-22 2:22 ` Hui Wang
2015-11-05 5:56 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009152810.GW32532@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@st.com \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox