Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>
Cc: Shunqian Zheng <zhengsq@rock-chips.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"pawel.moll@arm.com" <pawel.moll@arm.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
	"galak@codeaurora.org" <galak@codeaurora.org>,
	"heiko@sntech.de" <heiko@sntech.de>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"perex@perex.cz" <perex@perex.cz>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"benzh@chromium.org" <benzh@chromium.org>,
	"linux-rockchip@lists.infradead.org"
	<linux-rockchip@lists.infradead.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [alsa-devel] [PATCH v1 1/4] ASoC: codec: Inno codec driver for RK3036 SoC
Date: Mon, 19 Oct 2015 19:54:14 +0100	[thread overview]
Message-ID: <20151019185414.GO32054@sirena.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.02.1510190855250.4075@lnxricardw1.se.axis.com>

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

On Mon, Oct 19, 2015 at 08:56:51AM +0200, Ricard Wanderlof wrote:
> On Tue, 13 Oct 2015, Shunqian Zheng wrote:

> > +static const struct of_device_id rk3036_codec_of_match[] = {
> > +       { .compatible = "rk3036-codec", },
> > +       {}
> > +};
> > +MODULE_DEVICE_TABLE(of, rk3036_codec_of_match);

> Isn't a compatible string normally in the form "rockchip,rk3036-codec" ?

Yes, it needs vendor namespacing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2015-10-19 18:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13  1:01 [PATCH v1 0/4] Audio Codec Driver of RK3036 SoC Shunqian Zheng
2015-10-13  1:01 ` [PATCH v1 1/4] ASoC: codec: Inno codec driver for " Shunqian Zheng
2015-10-19  6:56   ` [alsa-devel] " Ricard Wanderlof
2015-10-19 18:54     ` Mark Brown [this message]
2015-10-19 19:09   ` Mark Brown
2015-11-05  9:52     ` Shunqian Zheng
2015-10-13  1:01 ` [PATCH v1 2/4] ASoC: RK3036: Add binding doc of inno-rk3036 codec driver Shunqian Zheng
     [not found] ` <1444698070-4191-1-git-send-email-zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2015-10-13  1:01   ` [PATCH v1 3/4] ASoC: Add codec machine driver for RK3036 Shunqian Zheng
2015-10-19 12:12     ` Sjoerd Simons
2015-10-19 19:13     ` Mark Brown
2015-10-24  3:18       ` Shunqian Zheng
2015-10-13  1:01 ` [PATCH v1 4/4] ASoC: RK3036: Add binding doc for audio machine driver Shunqian Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151019185414.GO32054@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=benzh@chromium.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=perex@perex.cz \
    --cc=ricard.wanderlof@axis.com \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    --cc=zhengsq@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox