From: Vinod Koul <vinod.koul@intel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Mythri P K <mythri.p.k@intel.com>,
patches.audio@intel.com, liam.r.girdwood@linux.intel.com,
broonie@kernel.org, Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH 1/3] ASoC: dapm: Add kcontrol support for PGAs
Date: Tue, 20 Oct 2015 22:16:25 +0530 [thread overview]
Message-ID: <20151020164625.GD27370@localhost> (raw)
In-Reply-To: <562664B6.7090807@metafoo.de>
On Tue, Oct 20, 2015 at 05:58:46PM +0200, Lars-Peter Clausen wrote:
> > -static int dapm_create_or_share_mixmux_kcontrol(struct snd_soc_dapm_widget *w,
> > - int kci)
> > +static int dapm_create_or_share_mixmuxpga_kcontrol(
>
> ... but maybe just call it dapm_create_or_share_kcontrol()
I don't mind that
>
> > + struct snd_soc_dapm_widget *w, int kci)
> > {
> > struct snd_soc_dapm_context *dapm = w->dapm;
> > struct snd_card *card = dapm->card->snd_card;
> > @@ -822,6 +822,10 @@ static int dapm_create_or_share_mixmux_kcontrol(struct snd_soc_dapm_widget *w,
> > wname_in_long_name = true;
> > kcname_in_long_name = false;
> > break;
> > + case snd_soc_dapm_pga:
>
> This should have the same behavior as mixers and switches, just add the case
> there instead having a different path.
Oh yes thanks for pointing out that makese better sense, will update in v2.
--
~Vinod
next prev parent reply other threads:[~2015-10-20 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 15:38 [PATCH 0/3] ASoC: dapm: add PGA kcontrol, dai_link enhancement & Vinod Koul
2015-10-20 15:38 ` [PATCH 1/3] ASoC: dapm: Add kcontrol support for PGAs Vinod Koul
2015-10-20 15:58 ` Lars-Peter Clausen
2015-10-20 16:46 ` Vinod Koul [this message]
2015-10-20 15:38 ` [PATCH 2/3] ASoC: dapm: Add startup & shutdown for dai_links Vinod Koul
2015-10-22 23:09 ` Applied "ASoC: dapm: Add startup & shutdown for dai_links" to the asoc tree Mark Brown
2015-10-20 15:38 ` [PATCH 3/3] ASoC: dapm: Add snd_soc_dapm_kcontrol_widget() Vinod Koul
2015-10-22 23:09 ` Applied "ASoC: dapm: Add snd_soc_dapm_kcontrol_widget()" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151020164625.GD27370@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=lars@metafoo.de \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mythri.p.k@intel.com \
--cc=patches.audio@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox