From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
lgirdwood@gmail.com,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
tiwai@suse.com
Subject: Re: [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE'
Date: Wed, 21 Oct 2015 16:36:14 +0100 [thread overview]
Message-ID: <20151021153614.GD10520@ck-lbox> (raw)
In-Reply-To: <20151021153248.GE27370@localhost>
On Wed, Oct 21, 2015 at 09:02:49PM +0530, Vinod Koul wrote:
> On Tue, Oct 20, 2015 at 08:37:11PM +0100, Mark Brown wrote:
> > On Tue, Oct 20, 2015 at 12:47:58PM -0500, Pierre-Louis Bossart wrote:
>
> > > If you need to set parameters maybe we should also change the definition of
> > > snd_enc_generic so that the reserved fields can be used for custom
> > > parameters, or document that their use is permitted for this sort of ID.
> >
> > It does mean the core can't grab them but quite what the core is
> > supposed to usefully do for something like this is unclear to me so...
>
> Well in case of compressed formats, core doesn't do anything, we just act as
> a transport and shove down data and information.
>
> I do like Pierre's idea of giving some meaning to formats and use some
> reserved fields, but somehow I can't think of a clean solution for this!
Personally, I feel a bit like doing nothing at the moment might
be the best solution. If BESPOKE is for icky stuff that won't be
generic trying to pull out generic fields to go in snd_enc_generic
seems like a challenging exercise, and we can look submissions
that use it and keep an eye out for anything that might be
generic enough to go in there, rather than adding a bunch of
stuff that ends up never getting used.
Thanks,
Charles
next prev parent reply other threads:[~2015-10-21 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 13:39 [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE Charles Keepax
2015-10-20 17:47 ` Pierre-Louis Bossart
2015-10-20 19:37 ` Mark Brown
2015-10-21 15:32 ` [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE' Vinod Koul
2015-10-21 15:36 ` Charles Keepax [this message]
2015-10-21 18:46 ` Pierre-Louis Bossart
2015-11-05 5:57 ` Vinod Koul
2015-11-05 9:50 ` Charles Keepax
2015-10-24 7:36 ` [RFC PATCH] ALSA: compress: Add SND_AUDIOCODEC_BESPOKE Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021153614.GD10520@ck-lbox \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).