From: Dan Carpenter <dan.carpenter@oracle.com>
To: subhransu.s.prusty@intel.com
Cc: alsa-devel@alsa-project.org
Subject: Re: ASoC: Intel: Skylake: Add SKL DSP initialization
Date: Wed, 21 Oct 2015 23:53:48 +0300 [thread overview]
Message-ID: <20151021205348.GB9839@mwanda> (raw)
Hello Subhransu S. Prusty,
The patch a750ba5f5a56: "ASoC: Intel: Skylake: Add SKL DSP
initialization" from Jul 10, 2015, leads to the following static
checker warning:
sound/soc/intel/skylake/skl-sst.c:270 skl_sst_dsp_init()
info: ignoring unreachable code.
sound/soc/intel/skylake/skl-sst.c
252 sst->dsp_ops = dsp_ops;
253 sst->fw_ops = skl_fw_ops;
254
255 ret = skl_ipc_init(dev, skl);
256 if (ret)
257 return ret;
258
259 ret = sst->fw_ops.load_fw(sst);
260 if (ret < 0) {
261 dev_err(dev, "Load base fw failed : %d", ret);
262 return ret;
Presumably this should be a "goto free_ipc;" here?
263 }
264
265 if (dsp)
266 *dsp = skl;
267
268 return 0;
269
270 skl_ipc_free(&skl->ipc);
^^^^^^^^^^^^^^^^^^^^^^^
Unreachable.
271 return ret;
272 }
273 EXPORT_SYMBOL_GPL(skl_sst_dsp_init);
regards,
dan carpenter
reply other threads:[~2015-10-21 20:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021205348.GB9839@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=subhransu.s.prusty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox