From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Girdwood, Liam R" <liam.r.girdwood@intel.com>
Subject: Re: [PATCH v4] ASoC: soc-compress: add config item for soc-compress to make it compiled only when needed
Date: Thu, 22 Oct 2015 13:51:46 +0100 [thread overview]
Message-ID: <20151022125146.GK8232@sirena.org.uk> (raw)
In-Reply-To: <20151014124659.GN8805@ck-lbox>
[-- Attachment #1.1: Type: text/plain, Size: 599 bytes --]
On Wed, Oct 14, 2015 at 01:46:59PM +0100, Charles Keepax wrote:
> On Wed, Oct 14, 2015 at 12:57:38PM +0000, Jie, Yang wrote:
> > Hi Charles, we used compress_dai bool before(in v2), but for that we need
> > add empty inline soc_compress_new(), Takashi suggest we use callback
> > func pointer here, it can be compress_new or any other creation here.
> > This is flexible and can be extended if any new stuff has to be handled.
> If everyone else is happy with it, then I don't mind. It
> obviously works, just felt a little odd to me.
Yes, it's not very nice but it does help finesse things. :/
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-10-22 23:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 15:41 [PATCH v4] ASoC: soc-compress: add config item for soc-compress to make it compiled only when needed Jie Yang
2015-10-14 9:20 ` Charles Keepax
2015-10-14 12:57 ` Jie, Yang
2015-10-14 12:46 ` Charles Keepax
2015-10-19 14:22 ` Jie, Yang
2015-10-22 12:51 ` Mark Brown [this message]
2015-10-22 23:09 ` Applied "ASoC: compress: add config item for soc-compress to make it compiled only when needed" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151022125146.GK8232@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=liam.r.girdwood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox