From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Jiada Wang <jiada_wang@mentor.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz,
tiwai@suse.com, patches@opensource.wolfsonmicro.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: wm8962: set ALC2 as non-volatile register
Date: Mon, 26 Oct 2015 08:40:13 +0000 [thread overview]
Message-ID: <20151026084013.GG10520@ck-lbox> (raw)
In-Reply-To: <1445577528-2354-1-git-send-email-jiada_wang@mentor.com>
On Fri, Oct 23, 2015 at 02:18:48PM +0900, Jiada Wang wrote:
> Previously ALC2 register is set as a volatile register, declare
> it as one of ALC Coefficients register together with other non-volatile
> registers will cause issue, in case wm8962 has enter suspend mode,
> and cache_only flag is set, any attempt to read from ALC2 will fail.
>
> Because the 5 status bits in ALC2 aren't used anywhere nor are useful
> to end user, so this patch removes ALC2 register from volatile
> register list to make ALC2 be possible to be accessed when cache_only
> flag is set.
>
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2015-10-26 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 5:18 [PATCH] ASoC: wm8962: set ALC2 as non-volatile register Jiada Wang
2015-10-26 8:40 ` Charles Keepax [this message]
2015-10-28 0:21 ` Applied "ASoC: wm8962: set ALC2 as non-volatile register" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151026084013.GG10520@ck-lbox \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jiada_wang@mentor.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox