From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH 1/3] ASoC: Intel: Skylake: fix missing machine device creation Date: Tue, 3 Nov 2015 23:28:01 +0530 Message-ID: <20151103175801.GI12910@localhost> References: <20151102153229.GP21326@localhost> <20151103112458.GO20228@sirena.org.uk> <5638A88E.5050908@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by alsa0.perex.cz (Postfix) with ESMTP id 69C02262631 for ; Tue, 3 Nov 2015 18:54:32 +0100 (CET) Content-Disposition: inline In-Reply-To: <5638A88E.5050908@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Keyon Cc: alsa-devel@alsa-project.org, patches.audio@intel.com, Omair M Abdullah , liam.r.girdwood@linux.intel.com, Mark Brown , Jeeja KP List-Id: alsa-devel@alsa-project.org On Tue, Nov 03, 2015 at 08:29:02PM +0800, Keyon wrote: > >I'm having a hard time seeing the difference between this and what's > >going on in sst-acpi. They seem to be doing the same thing in slightly > >different ways, they both match tables of CODEC IDs to machine driver > >names with the distinction being that this doesn't provide a firmware > >filename whereas sst-acpi does but the mechanics of mapping a CODEC to a > >machine driver seem otherwise the same. > > agree that it may be better if we can reuse(or merge with) sst > driver (intel/common/sst-acpi.c) for SKL. all drivers use different sst_machine structure... and data required is not same -- ~Vinod