From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: liam.r.girdwood@linux.intel.com, peter.ujfalusi@ti.com,
alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH] ASoC: damp: Reset dapm wcache after freeing damp widgets
Date: Tue, 10 Nov 2015 10:37:10 +0000 [thread overview]
Message-ID: <20151110103710.GI2549@ck-lbox> (raw)
In-Reply-To: <1447075826-641-1-git-send-email-jsarha@ti.com>
On Mon, Nov 09, 2015 at 03:30:26PM +0200, Jyri Sarha wrote:
> If there is anything in damp->path_source_cache or
> damp->path_sink_cache, it can not be valid after the widgets have been
> freed. Without this patch a repeated remove and load of a machine
> driver may cause NULL pointer reference in dapm_wcache_lookup() when a
> freed widget, not belonging to any list, is haunting in the wcache.
>
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> Reported-by: Felipe Balbi <balbi@ti.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2015-11-10 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 13:30 [PATCH] ASoC: damp: Reset dapm wcache after freeing damp widgets Jyri Sarha
2015-11-10 10:37 ` Charles Keepax [this message]
2015-11-10 11:31 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151110103710.GI2549@ck-lbox \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jsarha@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox