Re: [PATCH 2/4] ASoC: core: Adds support for cpu loopback dai_link

[Vinod Koul <vinod.koul@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1366 bytes --]

On Wed, Nov 18, 2015 at 01:17:57PM +0000, Mark Brown wrote:
> On Mon, Nov 09, 2015 at 11:19:59PM +0530, Vinod Koul wrote:
> > From: Jeeja KP <jeeja.kp@intel.com>
> > 
> > soc_link_dai_widgets() creates codec-codec loopback link which
> > allows DPCM to trigger these links and program the parameters for
> > these links These links are:
> > 
> > 	Codec1 Tx (Pb)  ----------> Rx Codec2 (Cap)
> > 	Codec2 Tx (Cap) <---------- Tx Codec1 (Pb)
> > 
> > But as we try to model a CPU based loops for non host links like
> > modem to codec loop, the above mapping gets wrong as:
> > 
> > 	CPU Tx (Pb)  -----------> Codec Tx (Pb)
> > 	CPU Rx (Cap) <----------- Codec Rx (Cap)
> > 
> > So we add a new flag to handle above scenario and link widgets as
> > depecited above
> 
> So, what I was really thinking of with the renaming was a bigger rename
> that updates the names in snd_soc_dai_driver and everything that comes
> from that.  That's a much bigger thing though, let me think about it a
> bit more.

ah, yes that kind of change does make sense, but as you observed that will
be a larger rework. And I think I am up for it in parallel to my SKL work :)

But that will take a bit of time and I would like update these in bits
rather than one shot

Let me know what you think and how you would like to approach this

Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]