From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [patch] ASoC: Intel: pass correct parameter in sst_alloc_stream_mrfld() Date: Wed, 18 Nov 2015 23:52:50 +0530 Message-ID: <20151118182249.GY25173@localhost> References: <20151118100255.GA15236@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20151118100255.GA15236@mwanda> Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Jie Yang , Jarkko Nikula , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Wed, Nov 18, 2015 at 01:04:20PM +0300, Dan Carpenter wrote: > "data" is always NULL in this function. I think we should be passing > "&data" to sst_prepare_and_post_msg() instead of "data". > > Fixes: 3d9ff34622ba ('ASoC: Intel: sst: add stream operations') > Signed-off-by: Dan Carpenter > --- > Not tested. This looks right to me but this should have resulted in broken stuff, I will test this tomorrow and get back -- ~Vinod