From: Mark Brown <broonie@kernel.org>
To: Moise Gergaud <moise.gergaud@st.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
arnaud.pouliquen@st.com, lgirdwood@gmail.com
Subject: Re: [PATCH 2/2] ASoC: sti: correction for HBRA support
Date: Mon, 30 Nov 2015 16:30:57 +0000 [thread overview]
Message-ID: <20151130163057.GA1929@sirena.org.uk> (raw)
In-Reply-To: <1448370996-30224-3-git-send-email-moise.gergaud@st.com>
[-- Attachment #1.1: Type: text/plain, Size: 676 bytes --]
On Tue, Nov 24, 2015 at 02:16:36PM +0100, Moise Gergaud wrote:
> Detect HBRA based on rate and channels used in the pcm session
> In case of HBRA:
> - CH_STS repeat is disabled
> - channel status sampling freq is not set if already set (because it can
> be a multiple of the runtime rate)
You might want to expand HBRA...
> switch (runtime->rate) {
> case 22050:
> - player->stream_settings.iec958.status[3] =
> - IEC958_AES3_CON_FS_22050;
> + *aes3 |= IEC958_AES3_CON_FS_22050;
> break;
This feels like someting we could have as a generic function for other
drivers to use - can you add a core function and then call it from your
driver please?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-11-30 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 13:16 [PATCH 0/2] correction of iec958 channel status sampling freq setting Moise Gergaud
2015-11-24 13:16 ` [PATCH 1/2] ASoC: sti: set iec958 channel status sampling freq Moise Gergaud
2015-11-25 13:00 ` Applied "ASoC: sti: set iec958 channel status sampling freq" to the asoc tree Mark Brown
2015-11-24 13:16 ` [PATCH 2/2] ASoC: sti: correction for HBRA support Moise Gergaud
2015-11-30 16:30 ` Mark Brown [this message]
2015-12-01 9:52 ` Moise Gergaud
2015-12-01 11:35 ` Mark Brown
2015-12-01 12:27 ` Moise Gergaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130163057.GA1929@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@st.com \
--cc=lgirdwood@gmail.com \
--cc=moise.gergaud@st.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox