Re: [PATCH 2/4] ASoC: core: Adds support for cpu loopback dai_link

[Vinod Koul <vinod.koul@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1267 bytes --]

On Mon, Nov 30, 2015 at 04:25:48PM +0000, Mark Brown wrote:
> On Wed, Nov 18, 2015 at 07:18:43PM +0530, Vinod Koul wrote:
> > On Wed, Nov 18, 2015 at 01:17:57PM +0000, Mark Brown wrote:
> 
> > > So, what I was really thinking of with the renaming was a bigger rename
> > > that updates the names in snd_soc_dai_driver and everything that comes
> > > from that.  That's a much bigger thing though, let me think about it a
> > > bit more.
> 
> > ah, yes that kind of change does make sense, but as you observed that will
> > be a larger rework. And I think I am up for it in parallel to my SKL work :)
> 
> > But that will take a bit of time and I would like update these in bits
> > rather than one shot
> 
> > Let me know what you think and how you would like to approach this
> 
> Can we make the temporary hack be to check if there's a CODEC defined
> in the DAI?  It's nasty and fragile but it keeps the hack much better
> isolated.

The flag added here, cpu_loopback would do that and keep this isolated from
the rest. The problem with checking if codec is defined will be for dsp
based loops which terminate in codec. It will not work as we will find codec
in the dailink for the voice call (modem-dsp-codec) loop

Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]