Re: [PATCH] ASoC: dapm: Replace siggen widget type with mic widgets

[Charles Keepax <ckeepax@opensource.wolfsonmicro.com>]

On Tue, Dec 01, 2015 at 07:36:13PM +0000, Mark Brown wrote:
> On Tue, Dec 01, 2015 at 07:57:11PM +0100, Lars-Peter Clausen wrote:
> > On 12/01/2015 06:32 PM, Charles Keepax wrote:
> 
> > > The siggen widget type doesn't really require its own special handling.
> > > It can be handled identically to a mic widget, ie. it is a source of a
> > > signal and causes things to power up when an output is connected.
> 
> > > However, as siggen widgets present as always on (the power check always
> > > returns 1), this leads to some odd interactions with DAPM.
> 
> > Sounds sensible, but I'd keep the siggen type and just change the
> > power_check callback. snd_soc_dapm_mic widgets are a bit special in that
> > they also influence how input and output widgets behave, we don't want the
> > same behavior for siggen widgets, since siggen widgets are internal to CODEC
> > while mic widgets are usually external.
> 
> Yeah, the siggen widgets were created because mics are funky - best to
> just fix the bug.

Thanks guys, will respin today.

Thanks,
Charles