Re: [PATCH v2 12/14] ASoC: hdac_hdmi: Add infoframe support for dp audio

From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
To: Daniel Stone <daniel@fooishbar.org>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com,
	lgirdwood@gmail.com, dri-devel <dri-devel@lists.freedesktop.org>,
	Vinod Koul <vinod.koul@intel.com>,
	broonie@kernel.org, Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH v2 12/14] ASoC: hdac_hdmi: Add infoframe support for dp audio
Date: Fri, 4 Dec 2015 16:02:10 +0530	[thread overview]
Message-ID: <20151204103210.GD6256@subhransu-desktop> (raw)
In-Reply-To: <CAPj87rNaWC7rpTMMNsO+86SkoqzfQtb_okChvE93s9KoXzOO9w@mail.gmail.com>

On Thu, Dec 03, 2015 at 05:13:16PM +0000, Daniel Stone wrote:
> Hi Subhransu,
> 
> On 3 December 2015 at 21:09, Subhransu S. Prusty
> <subhransu.s.prusty@intel.com> wrote:
> > +       if (conn_type == DRM_ELD_CONN_TYPE_HDMI) {
> > +               hdmi_audio_infoframe_init(&frame);
> > +
> > +               /* Default stereo for now */
> > +               frame.channels = channels;
> > +
> > +               ret = hdmi_audio_infoframe_pack(&frame, buffer, sizeof(buffer));
> > +               if (ret < 0)
> > +                       return ret;
> > +
> > +               dip = (u8 *)&frame;
> > +
> > +       } else if (conn_type == DRM_ELD_CONN_TYPE_DP) {
> > +               memset(&dp_ai, 0, sizeof(dp_ai));
> > +               dp_ai.type      = 0x84;
> > +               dp_ai.len       = 0x1b;
> > +               dp_ai.ver       = 0x11 << 2;
> > +               dp_ai.CC02_CT47 = channels - 1;
> > +               dp_ai.CA        = 0;
> > +
> > +               dip = (u8 *)&dip;
> 
> Surely this should be dip = (u8 *) &dp_ai, instead of pointing to itself?

Thanks for pointing. It's a mistake, will fix it.

Regards,
Subhansu
> 
> Cheers,
> Daniel
> 

-- 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel