Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ryan C. Underwood" <nemesis@icequake.net>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: alsa-devel@alsa-project.org, stsp@list.ru
Subject: Re: rawmidi virtual and long sysexes
Date: Tue, 22 Dec 2015 10:11:47 -0800	[thread overview]
Message-ID: <20151222181147.GL28165@localhost.localdomain> (raw)
In-Reply-To: <821A542B-D0E2-4AD5-A3EF-18A937735B3B@ladisch.de>


[-- Attachment #1.1: Type: text/plain, Size: 1426 bytes --]

On Tue, Dec 22, 2015 at 06:51:47AM +0100, Clemens Ladisch wrote:
> Ryan C. Underwood wrote:
> >Basically, the rawmidi virtual plugin enforces a 256-byte limit on
> >events, and emits multiple events if e.g. a >256 byte sysex is
> >encountered.
> 
> All sequencer clients have such a limit.

I was not objecting to a limit.  I was questioning the utility of a
_hard-coded_ limit.

> >This does not seem to be documented behavior for
> >snd_seq_event_input(), nor is the fixed limit described anywhere.
> 
> Yes, the documentation is lacking.

What's the best way to submit a documentation change, patch the docs
embedded in the code and mail that here?

> >Would it be better if the maximum event size could be configured
> >through params?  That would avoid needing this clumsy workaround by
> >sequencer clients.
> 
> Handling split messages cannot be avoided; the API is not
> capable of sending arbitrarily large messages.

So, the client writing to rawmidi has local knowledge about the
largest sysex he will generate.  I only propose that alsa-lib be
willing to accept this local knowledge over its own hard-coded default
when sizing the event buffer.  (For example, the device buffer size is
configurable by the sequencer client.)

Of course, I won't bother if such a patch would be rejected, and will
instead change the documentation.

-- 
Ryan C. Underwood, <nemesis@icequake.net>

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 173 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2015-12-22 18:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-19 23:31 rawmidi virtual and long sysexes Ryan C. Underwood
2015-12-22  5:51 ` Clemens Ladisch
2015-12-22 18:11   ` Ryan C. Underwood [this message]
2015-12-22 20:23     ` Stas Sergeev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151222181147.GL28165@localhost.localdomain \
    --to=nemesis@icequake.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=clemens@ladisch.de \
    --cc=stsp@list.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox