From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: vinod.koul@intel.com, jeeja.kp@intel.com,
alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: arizona: Exit startup early if no runtime
Date: Tue, 29 Dec 2015 09:46:40 +0000 [thread overview]
Message-ID: <20151229094640.GC6058@localhost.localdomain> (raw)
In-Reply-To: <20151224194105.GK579@sirena.org.uk>
On Thu, Dec 24, 2015 at 07:41:05PM +0000, Mark Brown wrote:
> On Wed, Dec 23, 2015 at 12:48:01PM +0000, Charles Keepax wrote:
> > commit 9b8ef9f6b3fc ("ASoC: dapm: Add startup & shutdown for dai_links")
> >
> > Added support for calling startup on CODEC to CODEC links, however this
> > is called with a NULL runtime pointer. There isn't really a sensible way
> > to pass a valid runtime pointer to a CODEC to CODEC link at the moment,
> > so we need to make the startup function safe for NULL runtimes. This
> > patch returns from the Arizona startup function early if there is no
> > runtime.
>
> We need a bit more here about why it's safe to just skip this code - it
> is actually safe since we're just setting constraints for userspace but
> that's not something the reader can tell without looking for more
> context.
Yeah no problem I will respin and send out a new version today.
Thanks,
Charles
next prev parent reply other threads:[~2015-12-29 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 12:48 [PATCH] ASoC: arizona: Exit startup early if no runtime Charles Keepax
2015-12-24 19:41 ` Mark Brown
2015-12-29 9:46 ` Charles Keepax [this message]
2015-12-30 18:05 ` Applied "ASoC: arizona: Exit startup early if no runtime" to the asoc tree Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2015-12-29 9:49 [PATCH] ASoC: arizona: Exit startup early if no runtime Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151229094640.GC6058@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox