From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Cc: Jean-Francois Moine <moinejf@free.fr>,
alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>,
Liam Girdwood <lgirdwood@gmail.com>, Jyri Sarha <jsarha@ti.com>,
Takashi Iwai <tiwai@suse.de>, Mark Brown <broonie@kernel.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>
Subject: Re: [RFC 4/6] drm: sti: Add ASoC generic hdmi codec support.
Date: Tue, 19 Jan 2016 17:06:45 +0000 [thread overview]
Message-ID: <20160119170644.GP19062@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1453210836-16218-5-git-send-email-arnaud.pouliquen@st.com>
On Tue, Jan 19, 2016 at 02:40:34PM +0100, Arnaud Pouliquen wrote:
> + /* update N parameter */
> + ret = hdmi_audio_compute_n_cts(params->sample_rate,
> + hdmi->mode.clock, &n_cts);
> + if (ret < 0)
> + return ret;
> +
> + DRM_DEBUG_DRIVER("sample_frequency= %d, pix clock = %d\n",
> + params->sample_rate, hdmi->mode.clock);
> + DRM_DEBUG_DRIVER("n= %d, cts = %d\n", n_cts.n, n_cts.cts);
> +
> + hdmi_write(hdmi, n_cts.n, HDMI_AUDN);
This looks like you only make use of the N parameter, which suggests
that your hardware measures the CTS parameter itself - which means
you have the non-coherent clock case. You'll want to refer to the
HDMI specs and use different N values from the coherent case.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2016-01-19 17:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 13:40 [RFC 0/6] sti: add audio interface to the hdmi driver Arnaud Pouliquen
2016-01-19 13:40 ` [RFC 1/6] video: hdmi: add helper function for N and CTS Arnaud Pouliquen
2016-01-19 16:54 ` Russell King - ARM Linux
2016-01-19 17:14 ` Mark Brown
2016-01-20 13:26 ` Arnaud Pouliquen
2016-01-20 13:39 ` Russell King - ARM Linux
2016-01-19 13:40 ` [RFC 2/6] ALSA: pcm: add IEC958 channel status control helper Arnaud Pouliquen
2016-01-19 17:00 ` Russell King - ARM Linux
2016-01-20 14:16 ` Arnaud Pouliquen
2016-01-19 13:40 ` [RFC 3/6] ASoC: core: add code to complete dai init after pcm creation Arnaud Pouliquen
2016-01-19 13:40 ` [RFC 4/6] drm: sti: Add ASoC generic hdmi codec support Arnaud Pouliquen
2016-01-19 17:06 ` Russell King - ARM Linux [this message]
2016-01-19 13:40 ` [RFC 5/6] ASoc: hdmi-codec: add IEC control Arnaud Pouliquen
2016-01-19 13:40 ` [RFC 6/6] ARM: DT: b2120: add audio HDMI dai link in audio card Arnaud Pouliquen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160119170644.GP19062@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@st.com \
--cc=benjamin.gaignard@linaro.org \
--cc=broonie@kernel.org \
--cc=jsarha@ti.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=moinejf@free.fr \
--cc=p.zabel@pengutronix.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).