From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: avoid unused variable warning for
	rt5659_acpi_match
Date: Wed, 20 Jan 2016 10:45:55 +0000
Message-ID: <20160120104555.GY6588@sirena.org.uk>
References: <2238845.aZnycJVYKR@wuerfel>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============7910927722251392399=="
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk
 [106.187.55.193])
 by alsa0.perex.cz (Postfix) with ESMTP id 563BC260412
 for <alsa-devel@alsa-project.org>; Wed, 20 Jan 2016 11:46:07 +0100 (CET)
In-Reply-To: <2238845.aZnycJVYKR@wuerfel>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Arnd Bergmann <arnd@arndb.de>
Cc: Oder Chiou <oder_chiou@realtek.com>, alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org, Bard Liao <bardliao@realtek.com>, linux-arm-kernel@lists.infradead.org
List-Id: alsa-devel@alsa-project.org


--===============7910927722251392399==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="x6I3On15oG0ucwLF"
Content-Disposition: inline


--x6I3On15oG0ucwLF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 20, 2016 at 11:43:48AM +0100, Arnd Bergmann wrote:
> The newly added rt5659 codec driver unconditionally defines an
> ACPI device match table but then uses ACPI_PTR() to remove the
> only reference to it, so we get a harmless build warning:

> sound/soc/codecs/rt5659.c:4200:30: warning: 'rt5659_acpi_match' defined but not used [-Wunused-variable]
>  static struct acpi_device_id rt5659_acpi_match[] = {

> This removes the ACPI_PTR() to avoid the warning.

Why is this a better fix than conditionally defining the table?

--x6I3On15oG0ucwLF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWn2ViAAoJECTWi3JdVIfQogMH/AxFJFkXdcV1cbhLQoflo8M3
F1za7C4wHat0os/ytTyiVGXGeJhCotkQ4vKbY6V1H/SmjZp/qTC/fAI9mSqb/tkH
lroGlXnZTl1OaLqf2YYgV8cbk3HGi3ECX5ZSmsuonDGjwRDPQ4TyIgvaiOah801K
IcOx1DbaLWOyyRVRAB+CJ3YI35CqPHwOfPomXGd63vfwV3u2k5z5ImmhPXm4jwEW
3CFCxpH3Mmu/6eyAOVbNwdYHtRINWcddeMcGXsnmuZ9e4ntFVOMOSllfWAoJLET+
jGBauHTtEL+y6B/BmBXR04LTE3anY7oFVa0gFYbK9sv1KC68BapOmy6C6PGlBoQ=
=sE+a
-----END PGP SIGNATURE-----

--x6I3On15oG0ucwLF--

--===============7910927722251392399==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


--===============7910927722251392399==--