From: Mark Brown <broonie@kernel.org>
To: anish kumar <yesanishhere@gmail.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.com, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: Add max98926 codec driver
Date: Wed, 27 Jan 2016 20:24:15 +0000 [thread overview]
Message-ID: <20160127202415.GD25316@sirena.org.uk> (raw)
In-Reply-To: <1452809013-8825-1-git-send-email-yesanishhere@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 688 bytes --]
On Thu, Jan 14, 2016 at 02:03:33PM -0800, anish kumar wrote:
> +static const struct snd_kcontrol_new max98926_dai_controls[] = {
> + SOC_DAPM_SINGLE("Left", MAX98926_GAIN,
> + MAX98926_DAC_IN_SEL_SHIFT, 0, 0),
> + SOC_DAPM_SINGLE("Right", MAX98926_GAIN,
> + MAX98926_DAC_IN_SEL_SHIFT, 1, 0),
> + SOC_DAPM_SINGLE("LeftRight", MAX98926_GAIN,
> + MAX98926_DAC_IN_SEL_SHIFT, 2, 0),
These are on/off switches too and so should end in Switch like all the
other on/off controls. Other than this the driver looks good so I've
applied it, please send a followup patch correcting this.
> + SOC_DAPM_SINGLE("(Left+Right)/2 Switch", MAX98926_GAIN,
> + MAX98926_DAC_IN_SEL_SHIFT, 3, 0),
> +};
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-01-27 20:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 22:03 [PATCH] ASoC: Add max98926 codec driver anish kumar
2016-01-27 20:24 ` Mark Brown [this message]
2016-01-27 20:24 ` Applied "ASoC: Add max98926 codec driver" to the asoc tree Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2016-01-04 22:29 [PATCH] ASoC: Add max98926 codec driver anish kumar
2016-01-10 12:52 ` Mark Brown
2015-12-01 18:31 anish kumar
2015-12-01 19:23 ` kbuild test robot
2015-12-08 19:10 ` Mark Brown
2015-05-29 20:32 Anish Kumar
2015-06-02 20:30 ` Mark Brown
2015-06-10 22:17 ` anish kumar
2015-06-15 16:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160127202415.GD25316@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.com \
--cc=yesanishhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).