* [PATCH v3] amixer: skip showing asoc tlv byte controls
@ 2016-01-28 7:26 Vinod Koul
2016-01-28 7:29 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Vinod Koul @ 2016-01-28 7:26 UTC (permalink / raw)
To: alsa-devel; +Cc: liam.r.girdwood, tiwai, broonie, Vinod Koul, patches.audio
ASoC TLV Byte controls are very large size controls so we should add new
options for these. So skip dumping contents for these.
$amixer -c0 cget numid=16
numid=16,iface=MIXER,name='mdl params'
; type=BYTES,access=-----RW-,values=30336
: ASoC TLV Byte control, skipping bytes dump
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
amixer/amixer.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/amixer/amixer.c b/amixer/amixer.c
index db1849333da3..e059c176f958 100644
--- a/amixer/amixer.c
+++ b/amixer/amixer.c
@@ -682,6 +682,14 @@ static int show_control(const char *space, snd_hctl_elem_t *elem,
__skip_read:
if (!snd_ctl_elem_info_is_tlv_readable(info))
goto __skip_tlv;
+ /* skip ASoC ext bytes controls that may have huge binary TLV data */
+ if (type == SND_CTL_ELEM_TYPE_BYTES &&
+ !snd_ctl_elem_info_is_readable(info) &&
+ !snd_ctl_elem_info_is_writable(info)) {
+ printf("%s: ASoC TLV Byte control, skipping bytes dump\n", space);
+ goto __skip_tlv;
+ }
+
tlv = malloc(4096);
if ((err = snd_hctl_elem_tlv_read(elem, tlv, 4096)) < 0) {
error("Control %s element TLV read error: %s\n", card, snd_strerror(err));
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] amixer: skip showing asoc tlv byte controls
2016-01-28 7:26 [PATCH v3] amixer: skip showing asoc tlv byte controls Vinod Koul
@ 2016-01-28 7:29 ` Takashi Iwai
2016-01-28 8:24 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2016-01-28 7:29 UTC (permalink / raw)
To: Vinod Koul; +Cc: liam.r.girdwood, patches.audio, alsa-devel, broonie
On Thu, 28 Jan 2016 08:26:06 +0100,
Vinod Koul wrote:
>
> ASoC TLV Byte controls are very large size controls so we should add new
> options for these. So skip dumping contents for these.
>
> $amixer -c0 cget numid=16
> numid=16,iface=MIXER,name='mdl params'
> ; type=BYTES,access=-----RW-,values=30336
> : ASoC TLV Byte control, skipping bytes dump
Use semicolon instead.
Takashi
>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> ---
> amixer/amixer.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/amixer/amixer.c b/amixer/amixer.c
> index db1849333da3..e059c176f958 100644
> --- a/amixer/amixer.c
> +++ b/amixer/amixer.c
> @@ -682,6 +682,14 @@ static int show_control(const char *space, snd_hctl_elem_t *elem,
> __skip_read:
> if (!snd_ctl_elem_info_is_tlv_readable(info))
> goto __skip_tlv;
> + /* skip ASoC ext bytes controls that may have huge binary TLV data */
> + if (type == SND_CTL_ELEM_TYPE_BYTES &&
> + !snd_ctl_elem_info_is_readable(info) &&
> + !snd_ctl_elem_info_is_writable(info)) {
> + printf("%s: ASoC TLV Byte control, skipping bytes dump\n", space);
> + goto __skip_tlv;
> + }
> +
> tlv = malloc(4096);
> if ((err = snd_hctl_elem_tlv_read(elem, tlv, 4096)) < 0) {
> error("Control %s element TLV read error: %s\n", card, snd_strerror(err));
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] amixer: skip showing asoc tlv byte controls
2016-01-28 7:29 ` Takashi Iwai
@ 2016-01-28 8:24 ` Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2016-01-28 8:24 UTC (permalink / raw)
To: Takashi Iwai; +Cc: liam.r.girdwood, patches.audio, alsa-devel, broonie
On Thu, Jan 28, 2016 at 08:29:57AM +0100, Takashi Iwai wrote:
> On Thu, 28 Jan 2016 08:26:06 +0100,
> Vinod Koul wrote:
> >
> > ASoC TLV Byte controls are very large size controls so we should add new
> > options for these. So skip dumping contents for these.
> >
> > $amixer -c0 cget numid=16
> > numid=16,iface=MIXER,name='mdl params'
> > ; type=BYTES,access=-----RW-,values=30336
> > : ASoC TLV Byte control, skipping bytes dump
>
> Use semicolon instead.
Sure, I tried to use the existing style, what is the interpretation of
these?
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-28 8:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-28 7:26 [PATCH v3] amixer: skip showing asoc tlv byte controls Vinod Koul
2016-01-28 7:29 ` Takashi Iwai
2016-01-28 8:24 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).