From: Mark Brown <broonie@kernel.org>
To: Damien Horsley <Damien.Horsley@imgtec.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: pcm3168a: Call clk_set_rate in pcm3168a_set_dai_sysclk
Date: Fri, 29 Jan 2016 00:15:23 +0100 [thread overview]
Message-ID: <20160128231523.GE4130@sirena.org.uk> (raw)
In-Reply-To: <1454000060-8407-1-git-send-email-Damien.Horsley@imgtec.com>
[-- Attachment #1: Type: text/plain, Size: 329 bytes --]
On Thu, Jan 28, 2016 at 04:54:20PM +0000, Damien Horsley wrote:
> + ret = clk_set_rate(pcm3168a->scki, freq);
> + if (ret)
> + return ret;
> +
> pcm3168a->sysclk = freq;
Since the clock appears to be mandatory in this driver (good!) why are
we even storing sysclk? Just remove it, the driver never actually used
it anyway.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-28 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 16:54 [PATCH] ASoC: pcm3168a: Call clk_set_rate in pcm3168a_set_dai_sysclk Damien Horsley
2016-01-28 23:15 ` Mark Brown [this message]
2016-01-29 0:16 ` Applied "ASoC: pcm3168a: Call clk_set_rate in pcm3168a_set_dai_sysclk" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128231523.GE4130@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Damien.Horsley@imgtec.com \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).