From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH] amixer: add support for TLV byte control read
Date: Fri, 29 Jan 2016 19:23:44 +0530 [thread overview]
Message-ID: <20160129135343.GV11130@localhost> (raw)
In-Reply-To: <s5hk2ms5xun.wl-tiwai@suse.de>
On Fri, Jan 29, 2016 at 02:17:20PM +0100, Takashi Iwai wrote:
> > with this change it works and dumps 4K bytes on my screen
> >
> > @@ -913,6 +913,13 @@ static int skl_tplg_tlv_control_get(struct snd_kcontrol
> > *kcontrol,
> > skl_get_module_params(skl->skl_sst, (u32 *)bc->params,
> > bc->max, bc->param_id, mconfig);
> >
> > + /* decrement size for TLV header */
> > + size -= 2 * sizeof(u32);
>
> The lower bound check is also missing.
>
> if (size < 2 * sizeof(u32))
> return -EINVAL;
I thought core and lib do check this, but yes no harm in adding will do so
Thanks
--
~Vinod
next prev parent reply other threads:[~2016-01-29 13:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 5:46 [PATCH] amixer: add support for TLV byte control read Vinod Koul
2016-01-22 6:19 ` Takashi Iwai
2016-01-22 7:46 ` Vinod Koul
2016-01-22 8:09 ` Takashi Iwai
2016-01-22 8:26 ` Takashi Iwai
2016-01-22 9:57 ` Vinod Koul
2016-01-22 9:56 ` Vinod Koul
2016-01-22 10:50 ` Takashi Iwai
2016-01-27 17:47 ` Vinod Koul
2016-01-27 18:49 ` Takashi Iwai
2016-01-28 4:25 ` Vinod Koul
2016-01-28 5:49 ` Takashi Iwai
2016-01-28 9:26 ` Vinod Koul
2016-01-28 16:19 ` Takashi Iwai
2016-01-29 6:51 ` Vinod Koul
2016-01-29 11:13 ` Vinod Koul
2016-01-29 13:17 ` Takashi Iwai
2016-01-29 13:53 ` Vinod Koul [this message]
2016-01-29 13:53 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129135343.GV11130@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).