From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: arizona: Add support for SNDRV_PCM_RATE_KNOT
Date: Wed, 3 Feb 2016 09:41:13 +0000 [thread overview]
Message-ID: <20160203094113.GT1490@localhost.localdomain> (raw)
In-Reply-To: <56B1B939.5030503@metafoo.de>
On Wed, Feb 03, 2016 at 09:24:25AM +0100, Lars-Peter Clausen wrote:
> On 02/02/2016 08:30 PM, Mark Brown wrote:
> > On Tue, Feb 02, 2016 at 04:38:04PM +0000, Charles Keepax wrote:
> >
> >> +#define ARIZONA_48K_RATES 12000, 24000, 48000, 96000, 192000, 4000, 8000, \
> >> + 16000, 32000
> >
> > This just looks wrong. It's valid code but with the combination of the
> > split line and the list without any sort of parenthesis it sets off
> > alarm bells. Duplicating might not be the worst thing ever...
>
> For list constraints it is possible to specify a mask for which of the
> entries in the rates array should be considered. So you could use the same
> rate array, but use different masks. The adau1977 drive for example does this.
>
>
Thanks wasn't aware of that I will have a look and respin the
patch.
Thanks,
Charles
next prev parent reply other threads:[~2016-02-03 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 16:38 [PATCH] ASoC: arizona: Add support for SNDRV_PCM_RATE_KNOT Charles Keepax
2016-02-02 19:30 ` Mark Brown
2016-02-03 8:24 ` Lars-Peter Clausen
2016-02-03 9:41 ` Charles Keepax [this message]
2016-02-04 12:45 ` Charles Keepax
2016-02-04 12:55 ` Lars-Peter Clausen
2016-02-04 14:34 ` Charles Keepax
2016-02-04 12:46 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203094113.GT1490@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).