From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org,
"Dharageswari.R" <dharageswari.r@intel.com>,
Guneshwor Singh <guneshwor.o.singh@intel.com>
Subject: Re: [PATCH 02/11] ASoC: Intel: Skylake: Fix delay wrap condition
Date: Thu, 4 Feb 2016 20:33:48 +0530 [thread overview]
Message-ID: <20160204150347.GB2531@localhost> (raw)
In-Reply-To: <20160204112436.GM4455@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 432 bytes --]
On Thu, Feb 04, 2016 at 11:24:36AM +0000, Mark Brown wrote:
> On Wed, Feb 03, 2016 at 05:59:45PM +0530, Vinod Koul wrote:
>
> > + delay = (hstream->bufsize == delay) ? 0 : delay;
>
> Please don't abuse the ternery operator, if you're not inserting it into
> the middle of another expression there's no reason not to use a normal
> if statement.
Ah okay. Sure I will send an update to modify this
Thanks
--
~Vinod
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-02-04 15:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 12:29 [PATCH 00/11] ASoC: Intel: Skylake: Driver fixes Vinod Koul
2016-02-03 12:29 ` [PATCH 01/11] ASoC: Intel: Skylake: Fix the memory overwrite of tlv buffer Vinod Koul
2016-02-04 12:16 ` Applied "ASoC: Intel: Skylake: Fix the memory overwrite of tlv buffer" to the asoc tree Mark Brown
2016-02-03 12:29 ` [PATCH 02/11] ASoC: Intel: Skylake: Fix delay wrap condition Vinod Koul
2016-02-04 11:24 ` Mark Brown
2016-02-04 15:03 ` Vinod Koul [this message]
2016-02-04 12:16 ` Applied "ASoC: Intel: Skylake: Fix delay wrap condition" to the asoc tree Mark Brown
2016-02-03 12:29 ` [PATCH 03/11] ASoC: Intel: Skylake: Fix mcps freeup after module unbind failure Vinod Koul
2016-02-04 12:16 ` Applied "ASoC: Intel: Skylake: Fix mcps freeup after module unbind failure" to the asoc tree Mark Brown
2016-02-03 12:29 ` [PATCH 04/11] ASoC: Intel: Skylake: Fix pipe memory allocation leak Vinod Koul
2016-02-04 12:16 ` Applied "ASoC: Intel: Skylake: Fix pipe memory allocation leak" to the asoc tree Mark Brown
2016-02-03 12:29 ` [PATCH 05/11] ASoC: Intel: Skylake: Fix return of skl_get_queue_index Vinod Koul
2016-02-04 12:16 ` Applied "ASoC: Intel: Skylake: Fix return of skl_get_queue_index" to the asoc tree Mark Brown
2016-02-03 12:29 ` [PATCH 06/11] ASoC: Intel: Skylake: Fix the module state check condition Vinod Koul
2016-02-04 12:16 ` Applied "ASoC: Intel: Skylake: Fix the module state check condition" to the asoc tree Mark Brown
2016-02-03 12:29 ` [PATCH 07/11] ASoC: Intel: Skylake: Fix not to stop sink pipe in pga pmd event Vinod Koul
2016-02-04 12:16 ` Applied "ASoC: Intel: Skylake: Fix not to stop sink pipe in pga pmd event" to the asoc tree Mark Brown
2016-02-03 12:29 ` [PATCH 08/11] ASoC: Intel: Skylake: Fix bind of source with multiple sinks Vinod Koul
2016-02-04 12:16 ` Applied "ASoC: Intel: Skylake: Fix bind of source with multiple sinks" to the asoc tree Mark Brown
2016-02-03 12:29 ` [PATCH 09/11] ASoC: Intel: Skylake: Add missing PRE/POST_PMU handlers for vmixer Vinod Koul
2016-02-04 12:16 ` Applied "ASoC: Intel: Skylake: Add missing PRE/POST_PMU handlers for vmixer" to the asoc tree Mark Brown
2016-02-03 12:29 ` [PATCH 10/11] ASoC: Intel: Skylake: Fix stereo DMIC record Vinod Koul
2016-02-04 12:16 ` Applied "ASoC: Intel: Skylake: Fix stereo DMIC record" to the asoc tree Mark Brown
2016-02-03 12:29 ` [PATCH 11/11] ASoC: Intel: Skylake: Remove autosuspend delay Vinod Koul
2016-02-04 12:16 ` Applied "ASoC: Intel: Skylake: Remove autosuspend delay" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204150347.GB2531@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dharageswari.r@intel.com \
--cc=guneshwor.o.singh@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).