From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: tiwai@suse.com, clemens@ladisch.de, hans.verkuil@cisco.com,
laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com,
javier@osg.samsung.com, pawel@osciak.com,
m.szyprowski@samsung.com, kyungmin.park@samsung.com,
perex@perex.cz, arnd@arndb.de, dan.carpenter@oracle.com,
tvboxspy@gmail.com, crope@iki.fi, ruchandani.tina@gmail.com,
corbet@lwn.net, chehabrafael@gmail.com, k.kozlowski@samsung.com,
stefanr@s5r6.in-berlin.de, inki.dae@samsung.com,
jh1009.sung@samsung.com, elfring@users.sourceforge.net,
prabhakar.csengg@gmail.com, sw0312.kim@samsung.com,
p.zabel@pengutronix.de, ricardo.ribalda@gmail.com,
labbott@fedoraproject.org, pierre-louis.bossart@linux.intel.com,
ricard.wanderlof@axis.com, julian@jusst.de,
takamichiho@gmail.com, dominic.sacre@gmx.de, misterpib@gmail.com,
daniel@zonque.org, gtmkramer@xs4all.nl, normalperson@yhbt.net,
joe@oampo.co.uk, linuxbugs@vittga
Subject: Re: [PATCH v2 20/22] media: au0828 add enable, disable source handlers
Date: Tue, 9 Feb 2016 11:42:28 -0200 [thread overview]
Message-ID: <20160209114228.70539d24@recife.lan> (raw)
In-Reply-To: <56B91E0A.90705@osg.samsung.com>
Em Mon, 08 Feb 2016 16:00:26 -0700
Shuah Khan <shuahkh@osg.samsung.com> escreveu:
> >>> + ret = __media_entity_pipeline_start(entity, pipe);
> >>> + if (ret) {
> >>> + pr_err("Start Pipeline: %s->%s Error %d\n",
> >>> + source->name, entity->name, ret);
> >>> + ret = __media_entity_setup_link(found_link, 0);
> >>> + pr_err("Deactive link Error %d\n", ret);
> >>> + goto end;
> >>> + }
> >>
> >> Hmm... isn't it to early to activate the pipeline here? My original
> >> guess is that, on the analog side, this should happen only at the stream
> >> on code. Wouldn't this break apps like mythTV?
>
> On analog side, there are a few ioctls that
> change the configuration on the tuner way
> before stream on step. Is there a reason to
> separate the setup_link() and pipeline_start()
> steps? I can separate these two steps, but I
> am not really seeing the reason for that.
I'm actually ok with that, provided that it won't break existing
apps. Did you test it with MythTV?
Regards,
Mauro
next prev parent reply other threads:[~2016-02-09 13:42 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 4:03 [PATCH v2 00/22] Sharing media resources across ALSA and au0828 drivers Shuah Khan
2016-02-04 4:03 ` [PATCH v2 01/22] uapi/media.h: Declare interface types for ALSA Shuah Khan
2016-02-04 8:38 ` Mauro Carvalho Chehab
2016-02-04 4:03 ` [PATCH v2 03/22] media: Media Controller register/unregister entity_notify API Shuah Khan
2016-02-04 9:03 ` Mauro Carvalho Chehab
2016-02-04 4:03 ` [PATCH v2 04/22] media: Media Controller enable/disable source handler API Shuah Khan
2016-02-04 4:03 ` [PATCH v2 05/22] media: Media Controller export non locking __media_entity_setup_link() Shuah Khan
2016-02-04 4:03 ` [PATCH v2 06/22] media: Media Controller non-locking __media_entity_pipeline_start/stop() Shuah Khan
[not found] ` <5c5a74a0d87db11dd1519248d8fda5c8fa9826be.1454557589.git.shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-02-04 9:18 ` Mauro Carvalho Chehab
2016-02-04 15:00 ` Shuah Khan
2016-02-04 4:03 ` [PATCH v2 07/22] media: v4l-core add enable/disable source common interfaces Shuah Khan
[not found] ` <7df34ecdf35d473535abefa6643b2db24457b8e6.1454557589.git.shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-02-04 6:29 ` kbuild test robot
2016-02-04 9:25 ` Mauro Carvalho Chehab
2016-02-04 4:03 ` [PATCH v2 08/22] media: Move au8522_media_pads enum to au8522.h from au8522_priv.h Shuah Khan
2016-02-04 4:03 ` [PATCH v2 09/22] media: au8522 change to create MC pad for ALSA Audio Out Shuah Khan
2016-02-04 4:03 ` [PATCH v2 10/22] media: Change v4l-core to check if source is free Shuah Khan
2016-02-04 4:03 ` [PATCH v2 12/22] media: au0828 video remove au0828_enable_analog_tuner() Shuah Khan
[not found] ` <8d43a2cfe4dcdf843d2e587e35a4bd4681eebe36.1454557589.git.shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-02-04 9:37 ` Mauro Carvalho Chehab
2016-02-04 14:49 ` Shuah Khan
[not found] ` <cover.1454557589.git.shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-02-04 4:03 ` [PATCH v2 02/22] media: Add ALSA Media Controller function entities Shuah Khan
2016-02-04 8:40 ` Mauro Carvalho Chehab
2016-02-04 4:03 ` [PATCH v2 11/22] media: dvb-frontend invoke enable/disable_source handlers Shuah Khan
[not found] ` <a404ddaef8fbfbc291d5afa013888fbc239cde8e.1454557589.git.shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-02-04 9:35 ` Mauro Carvalho Chehab
2016-02-04 14:58 ` Shuah Khan
2016-02-04 4:03 ` [PATCH v2 13/22] media: au0828 video change to use v4l_enable_media_source() Shuah Khan
[not found] ` <fe282e5160ee480d9b4d792a94c94549c54545cd.1454557589.git.shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-02-04 10:00 ` Mauro Carvalho Chehab
2016-02-04 4:03 ` [PATCH v2 14/22] media: au0828 change to use Managed Media Controller API Shuah Khan
2016-02-04 10:05 ` Mauro Carvalho Chehab
2016-02-04 10:08 ` Mauro Carvalho Chehab
2016-02-04 4:03 ` [PATCH v2 15/22] media: au0828 handle media_init and media_register window Shuah Khan
2016-02-04 4:03 ` [PATCH v2 16/22] media: au0828 create tuner to decoder link in disabled state Shuah Khan
2016-02-04 4:03 ` [PATCH v2 17/22] media: au0828 disable tuner to demod link Shuah Khan
2016-02-04 4:03 ` [PATCH v2 18/22] media: au0828 Use au8522_media_pads enum for pad defines Shuah Khan
2016-02-04 4:03 ` [PATCH v2 19/22] media: au0828-core register entity_notify hook Shuah Khan
2016-02-04 4:03 ` [PATCH v2 20/22] media: au0828 add enable, disable source handlers Shuah Khan
2016-02-04 10:26 ` Mauro Carvalho Chehab
2016-02-08 22:42 ` Shuah Khan
2016-02-08 23:00 ` Shuah Khan
2016-02-09 13:42 ` Mauro Carvalho Chehab [this message]
2016-02-09 10:51 ` Mauro Carvalho Chehab
2016-02-04 4:03 ` [PATCH v2 21/22] sound/usb: Use Media Controller API to share media resources Shuah Khan
2016-02-04 10:36 ` Mauro Carvalho Chehab
2016-02-04 10:46 ` Takashi Iwai
2016-02-07 11:25 ` kbuild test robot
2016-02-04 4:03 ` [PATCH v2 22/22] media: Ensure media device unregister is done only once Shuah Khan
2016-02-04 10:40 ` Mauro Carvalho Chehab
2016-02-04 10:54 ` [PATCH v2 00/22] Sharing media resources across ALSA and au0828 drivers Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209114228.70539d24@recife.lan \
--to=mchehab@osg.samsung.com \
--cc=arnd@arndb.de \
--cc=chehabrafael@gmail.com \
--cc=clemens@ladisch.de \
--cc=corbet@lwn.net \
--cc=crope@iki.fi \
--cc=dan.carpenter@oracle.com \
--cc=daniel@zonque.org \
--cc=dominic.sacre@gmx.de \
--cc=elfring@users.sourceforge.net \
--cc=gtmkramer@xs4all.nl \
--cc=hans.verkuil@cisco.com \
--cc=inki.dae@samsung.com \
--cc=javier@osg.samsung.com \
--cc=jh1009.sung@samsung.com \
--cc=joe@oampo.co.uk \
--cc=julian@jusst.de \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=labbott@fedoraproject.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linuxbugs@vittga \
--cc=m.szyprowski@samsung.com \
--cc=misterpib@gmail.com \
--cc=normalperson@yhbt.net \
--cc=p.zabel@pengutronix.de \
--cc=pawel@osciak.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=prabhakar.csengg@gmail.com \
--cc=ricard.wanderlof@axis.com \
--cc=ricardo.ribalda@gmail.com \
--cc=ruchandani.tina@gmail.com \
--cc=sakari.ailus@linux.intel.com \
--cc=shuahkh@osg.samsung.com \
--cc=stefanr@s5r6.in-berlin.de \
--cc=sw0312.kim@samsung.com \
--cc=takamichiho@gmail.com \
--cc=tiwai@suse.com \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).