From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, patches.audio@intel.com,
alsa-devel@alsa-project.org,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
lgirdwood@gmail.com
Subject: Re: [PATCH v6 10/15] ASoC: hdac_hdmi: Fix possible memory leak in hw_params
Date: Tue, 16 Feb 2016 08:28:31 +0530 [thread overview]
Message-ID: <20160216025831.GP19598@localhost> (raw)
In-Reply-To: <20160215205726.GF18327@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 783 bytes --]
On Mon, Feb 15, 2016 at 08:57:26PM +0000, Mark Brown wrote:
> On Fri, Feb 12, 2016 at 07:46:10AM +0530, Subhransu S. Prusty wrote:
> > It's possible for hw_params to be called two times. So add NULL
> > check to prevent memory leak.
>
> Another fix?
Yes but can go in 4.6 as HDMI codec does not get created in 4.5 code. That
is why I didn't send this one in last fixes series
>
> > - dd = kzalloc(sizeof(*dd), GFP_KERNEL);
> > - if (!dd)
> > - return -ENOMEM;
> > + dd = (struct hdac_ext_dma_params *)
> > + snd_soc_dai_get_dma_data(dai, substream);
>
> If you need to cast away from void * that suggests a problem and it'd
> look a lot neater too.
I suspect there is no need for cast, we seem to ahve a habit for that, let
us check that
--
~Vinod
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-02-16 2:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 2:16 [PATCH v6 00/15] ASoC: hdac_hdmi: Add DP & notification support Subhransu S. Prusty
2016-02-12 2:16 ` [PATCH v6 01/15] ASoC: hdac_hdmi: Add hotplug notification and read ELD Subhransu S. Prusty
2016-02-15 20:58 ` Applied "ASoC: hdac_hdmi: Add hotplug notification and read ELD" to the asoc tree Mark Brown
2016-02-12 2:16 ` [PATCH v6 02/15] ASoC: hdac_hdmi: Apply constraints based on ELD Subhransu S. Prusty
2016-02-15 20:58 ` Applied "ASoC: hdac_hdmi: Apply constraints based on ELD" to the asoc tree Mark Brown
2016-02-12 2:16 ` [PATCH v6 03/15] ASoC: hdac_hdmi: Enable DP1.2 and all converters/pins Subhransu S. Prusty
2016-02-15 20:10 ` Mark Brown
2016-02-15 22:31 ` Takashi Iwai
2016-02-16 2:00 ` Mark Brown
2016-02-16 8:16 ` Takashi Iwai
2016-02-12 2:16 ` [PATCH v6 04/15] ASoC: hdac_hdmi: create dais based on number of cvts Subhransu S. Prusty
2016-02-12 2:16 ` [PATCH v6 05/15] ASoC: hdac_hdmi: Create widget/route based on nodes enumerated Subhransu S. Prusty
2016-02-12 2:16 ` [PATCH v6 06/15] ASoC: hdac_hdmi: Add jack reporting Subhransu S. Prusty
2016-02-15 20:58 ` Applied "ASoC: hdac_hdmi: Add jack reporting" to the asoc tree Mark Brown
2016-02-12 2:16 ` [PATCH v6 07/15] ASoC: hdac_hdmi: Enable playback on all enumerated ports Subhransu S. Prusty
2016-02-15 20:58 ` Applied "ASoC: hdac_hdmi: Enable playback on all enumerated ports" to the asoc tree Mark Brown
2016-02-12 2:16 ` [PATCH v6 08/15] drm/edid: Add API to help find connection type Subhransu S. Prusty
2016-02-15 20:25 ` Applied "drm/edid: Add API to help find connection type" to the asoc tree Mark Brown
2016-02-12 2:16 ` [PATCH v6 09/15] ASoC: hdac_hdmi: Add infoframe support for dp audio Subhransu S. Prusty
2016-02-12 2:16 ` [PATCH v6 10/15] ASoC: hdac_hdmi: Fix possible memory leak in hw_params Subhransu S. Prusty
2016-02-15 20:57 ` Mark Brown
2016-02-16 2:58 ` Vinod Koul [this message]
2016-02-12 2:16 ` [PATCH v6 11/15] ASoC: hdac_hdmi: Don't fail in dai startup to make userland happy Subhransu S. Prusty
2016-02-15 20:55 ` Mark Brown
2016-02-16 3:36 ` Vinod Koul
2016-02-12 2:16 ` [PATCH v6 12/15] ASoC: hdac_hdmi: Add PM support Subhransu S. Prusty
2016-02-12 2:16 ` [PATCH v6 13/15] ASoC: hdac_hdmi: Fix to keep codec power active during enumeration Subhransu S. Prusty
2016-02-12 2:16 ` [PATCH v6 14/15] ASoC: hdac_hdmi: Fix to reconfigure registers in runtime resume Subhransu S. Prusty
2016-02-12 2:16 ` [PATCH v6 15/15] ASoC: hdac_hdmi: Fix to wait for D3 before powering off codec Subhransu S. Prusty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216025831.GP19598@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).