From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, Jyri Sarha <jsarha@ti.com>,
linux-clk@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Kristo, Tero" <t-kristo@ti.com>
Subject: Re: [PATCH 4/4] ASoC: simple-card: Support for selecting system clocks by ID
Date: Tue, 16 Feb 2016 13:42:33 +0000 [thread overview]
Message-ID: <20160216134233.GN18327@sirena.org.uk> (raw)
In-Reply-To: <56C2F00C.8080809@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]
On Tue, Feb 16, 2016 at 11:46:52AM +0200, Peter Ujfalusi wrote:
> As for codecs, tlv320aic3106 is also pretty simple device from the outside, it
> can receive it's reference clock via:
> MCLK pin, GPIO2 pin or it can use the BCLK from the bus. Based on the incoming
> frequency it can use it directly or it needs to use the internal PLL to
> generate the cocks.
> It can output generated clock via GPIO1
That already sounds like there is room for configuration and hooking
into a wider clock tree - we've got three different source options and
an output plus a PLL that can presumably take in non-audio rates.
> I don't think it will bring any clarity or features we miss right now if we
> try to move CPU and codec drivers to clk API. IMHO.
You happen to be looking at a particularly simple system but things do
scale up and there's not a clear cutoff point which would allow us to
make a clear distinction between things that might get used in a simple
system and things that might need something more complex. This seems
particularly important when we're adding things to simple-card, we want
it to be usable with as many different devices as possible.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-16 13:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 14:11 [PATCH 0/4] ASoC: simple-card/davinci-mcasp: System clock configuration support Peter Ujfalusi
2016-02-15 14:11 ` [PATCH 1/4] ASoC: davinci-mcasp: Use defines for clkdiv IDs via DT binding header Peter Ujfalusi
2016-02-15 14:11 ` [PATCH 2/4] ASoC: davinci-mcasp: Improve the sysclk selection Peter Ujfalusi
2016-02-15 14:11 ` [PATCH 3/4] ASoC: simple-card: Add system-clock-direction DT parameter to dai nodes Peter Ujfalusi
2016-02-15 14:11 ` [PATCH 4/4] ASoC: simple-card: Support for selecting system clocks by ID Peter Ujfalusi
2016-02-15 15:26 ` Mark Brown
2016-02-16 9:46 ` Peter Ujfalusi
2016-02-16 13:42 ` Mark Brown [this message]
2016-02-16 19:13 ` Michael Turquette
2016-02-17 8:13 ` Peter Ujfalusi
2016-02-17 12:07 ` Mark Brown
2016-02-17 19:52 ` Peter Ujfalusi
2016-04-18 15:50 ` [alsa-devel] " Peter Ujfalusi
2016-04-18 16:29 ` Mark Brown
2016-04-21 22:29 ` Stephen Boyd
2016-04-22 11:52 ` Peter Ujfalusi
2016-04-22 12:08 ` Tero Kristo
2016-02-17 11:31 ` Mark Brown
2016-02-17 14:18 ` [alsa-devel] " Ricard Wanderlof
2016-02-22 3:21 ` Mark Brown
2016-02-16 12:46 ` Andreas Irestål
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216134233.GN18327@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.ujfalusi@ti.com \
--cc=sboyd@codeaurora.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).