From: Dan Carpenter <dan.carpenter@oracle.com>
To: jeeja.kp@intel.com
Cc: alsa-devel@alsa-project.org,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: Re: ASoC: hdac_hdmi: Add jack reporting
Date: Wed, 17 Feb 2016 11:32:23 +0300 [thread overview]
Message-ID: <20160217083223.GA31585@mwanda> (raw)
Hello Jeeja KP,
This is a semi-automatic email about new static checker warnings.
The patch 4a3478debf36: "ASoC: hdac_hdmi: Add jack reporting" from
Feb 12, 2016, leads to the following Smatch complaint:
sound/soc/codecs/hdac_hdmi.c:971 hdac_hdmi_present_sense()
warn: variable dereferenced before check 'edev' (see line 967)
sound/soc/codecs/hdac_hdmi.c
966 struct hdac_ext_device *edev = pin->edev;
967 struct hdac_hdmi_priv *hdmi = edev->private_data;
^^^^^^^^^^^^^^^^^^
Patch introduces a new dereference.
968 struct hdac_hdmi_pcm *pcm;
969 int val;
970
971 if (!edev)
^^^^^
Existing code assumed that edev could be NULL.
972 return;
973
regards,
dan carpenter
reply other threads:[~2016-02-17 8:32 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217083223.GA31585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=jeeja.kp@intel.com \
--cc=subhransu.s.prusty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).