alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* Re: ASoC: hdac_hdmi: Add jack reporting
@ 2016-02-17  8:32 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-02-17  8:32 UTC (permalink / raw)
  To: jeeja.kp; +Cc: alsa-devel, Subhransu S. Prusty

Hello Jeeja KP,

This is a semi-automatic email about new static checker warnings.

The patch 4a3478debf36: "ASoC: hdac_hdmi: Add jack reporting" from 
Feb 12, 2016, leads to the following Smatch complaint:

sound/soc/codecs/hdac_hdmi.c:971 hdac_hdmi_present_sense()
	 warn: variable dereferenced before check 'edev' (see line 967)

sound/soc/codecs/hdac_hdmi.c
   966		struct hdac_ext_device *edev = pin->edev;
   967		struct hdac_hdmi_priv *hdmi = edev->private_data;
                                              ^^^^^^^^^^^^^^^^^^
Patch introduces a new dereference.

   968		struct hdac_hdmi_pcm *pcm;
   969		int val;
   970	
   971		if (!edev)
                    ^^^^^
Existing code assumed that edev could be NULL.

   972			return;
   973	

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-02-17  8:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-17  8:32 ASoC: hdac_hdmi: Add jack reporting Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).