Re: [PATCH v2] ASoC: hdac_hdmi: Remove 'edev' NULL check

["Subhransu S. Prusty" <subhransu.s.prusty@intel.com>]

On Wed, Feb 17, 2016 at 09:42:13AM -0200, Fabio Estevam wrote:
> Commit 4a3478debf36 ("ASoC: hdac_hdmi: Add jack reporting") 
> leads to the following Smatch complaint:
> 
> sound/soc/codecs/hdac_hdmi.c:971 hdac_hdmi_present_sense()
>          warn: variable dereferenced before check 'edev' (see line 967)
> 
> As explained by Subhransu S. Prusty:
> 
> "This NULL check is not required, can be removed.
> 
> edev object is expected to be present when the present_sense is 
> called. This is called from places where this edev object is 
> already available."
> 
> So remove the evdev NULL check.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Acked-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>

> ---
> Changes since v1:
> - Remove NULL check (Subhransu)
> 
>  sound/soc/codecs/hdac_hdmi.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c
> index 36f1200..2884dbf 100644
> --- a/sound/soc/codecs/hdac_hdmi.c
> +++ b/sound/soc/codecs/hdac_hdmi.c
> @@ -968,9 +968,6 @@ static void hdac_hdmi_present_sense(struct hdac_hdmi_pin *pin, int repoll)
>  	struct hdac_hdmi_pcm *pcm;
>  	int val;
>  
> -	if (!edev)
> -		return;
> -
>  	pin->repoll_count = repoll;
>  
>  	pm_runtime_get_sync(&edev->hdac.dev);
> -- 
> 1.9.1
> 

--