alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] portman2x4 - use new parport device model
Date: Thu, 18 Feb 2016 16:07:59 +0530	[thread overview]
Message-ID: <20160218103747.GA12223@sudip-pc> (raw)
In-Reply-To: <s5hvb5muxoz.wl-tiwai@suse.de>

On Thu, Feb 18, 2016 at 11:20:28AM +0100, Takashi Iwai wrote:
> On Wed, 17 Feb 2016 13:56:27 +0100,
> Sudip Mukherjee wrote:
> > 
> > Modify portman driver to use the new parallel port device model.
> > The advantage of using the device model is that the device gets binded
> > to the hardware, we get the feature of hotplug, we can bind/unbind
> > the driver at runtime.
> > The changes are in the way the driver gets registered with the
> > parallel port subsystem and the temporary device to probe portman card
> > is removed and portman_probe() is used in the probe callback.
> > 
> > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > ---
> > 
> > v5: claimed flag and one call to parport_claim() removed.
> > v4: temporary device to probe is removed.
> > v3: changed commit message
> > v2:
> >  1. pardev_cb is initialized while declaring, thus removing the use of
> >  memset.
> >  2. used pdev->id.
> >  3. v1 did not have the parport probe callback, but we will need the
> >  probe callback for binding as the name of the driver and the name of
> >  the device is different.
> >  4. in v1 I missed modifying snd_portman_probe_port().
> 
> OK, I merged this one to for-next branch now.  Let's cross fingers :)

Thanks.
Its simple change, nothing should happen.
I will send you the other one in few days time if 0day does not report
anything on this patch.

regards
sudip

      reply	other threads:[~2016-02-18 10:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 12:56 [PATCH v5] portman2x4 - use new parport device model Sudip Mukherjee
2016-02-18 10:20 ` Takashi Iwai
2016-02-18 10:37   ` Sudip Mukherjee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218103747.GA12223@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).