From: Mark Brown <broonie@kernel.org>
To: anish kumar <yesanishhere@gmail.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: Add max9867 codec driver
Date: Thu, 18 Feb 2016 14:16:11 +0000 [thread overview]
Message-ID: <20160218141611.GF7129@sirena.org.uk> (raw)
In-Reply-To: <1455758929-24202-1-git-send-email-yesanishhere@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 616 bytes --]
On Wed, Feb 17, 2016 at 05:28:49PM -0800, anish kumar wrote:
> + if (pclk_bclk_ratio == 2)
> + bclk_value = MAX9867_IFC1B_PCLK_2;
> + else if (pclk_bclk_ratio == 4)
> + bclk_value = MAX9867_IFC1B_PCLK_4;
> + else if (pclk_bclk_ratio == 8)
> + bclk_value = MAX9867_IFC1B_PCLK_8;
> + else if (pclk_bclk_ratio == 16)
> + bclk_value = MAX9867_IFC1B_PCLK_16;
> + else {
> + dev_err(codec->dev, "unsupported sampling rate\n");
> + return -EINVAL;
> + }
> + break;
This looks like a switch statement, please write it as a switch
statement. Please send a followup patch implementing this.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-02-18 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 1:28 [PATCH] ASoC: Add max9867 codec driver anish kumar
2016-02-18 14:16 ` Mark Brown [this message]
2016-02-18 20:12 ` Applied "ASoC: Add max9867 codec driver" to the asoc tree Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2016-02-11 18:32 [PATCH] ASoC: Add max9867 codec driver anish kumar
2016-02-15 19:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218141611.GF7129@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=yesanishhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).