alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Vinod Koul <vinod.koul@intel.com>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
	alsa-devel@alsa-project.org, Alan Cox <alan@linux.intel.com>,
	Alan <gnomes@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 1/3] ASoC: Intel: Skylake: fix pointer scaling
Date: Sat, 20 Feb 2016 00:33:45 +0900	[thread overview]
Message-ID: <20160219153345.GO18327@sirena.org.uk> (raw)
In-Reply-To: <1455862354-6455-1-git-send-email-vinod.koul@intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 593 bytes --]

On Fri, Feb 19, 2016 at 11:42:32AM +0530, Vinod Koul wrote:
> From: Alan <gnomes@lxorguk.ukuu.org.uk>
> 
> skl_tplg_tlv_control_set does pointer maths on data but forgets that data
> is not uint8_t so the maths is already scaled in the pointer type.
> 
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>

Please ensure that the name and signoff match up.  I'm fairly sure that
both are for the same person here but it's not something I should have
to think about and it is important to ensure that we have signoffs for
everything.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  parent reply	other threads:[~2016-02-20 17:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19  6:12 [PATCH 1/3] ASoC: Intel: Skylake: fix pointer scaling Vinod Koul
2016-02-19  6:12 ` [PATCH 2/3] ASoC: Intel: Skylake: remove bogus comparison of an array with NULL Vinod Koul
2016-02-22  4:58   ` Applied "ASoC: Intel: Skylake: remove bogus comparison of an array with NULL" to the asoc tree Mark Brown
2016-02-19  6:12 ` [PATCH 3/3] ASoC: Intel: Skylake: Generate topology name for NHLT table header Vinod Koul
2016-02-20 17:16   ` Applied "ASoC: Intel: Skylake: Generate topology name for NHLT table header" to the asoc tree Mark Brown
2016-02-19 15:33 ` Mark Brown [this message]
2016-02-21  3:04   ` [PATCH 1/3] ASoC: Intel: Skylake: fix pointer scaling Vinod Koul
2016-02-22  3:16     ` Mark Brown
2016-02-22  3:33       ` Vinod Koul
2016-02-20 17:16 ` Applied "ASoC: Intel: Skylake: fix pointer scaling" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160219153345.GO18327@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alan@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).