alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Cc: tiwai@suse.de, patches.audio@intel.com,
	alsa-devel@alsa-project.org, Vinod Koul <vinod.koul@intel.com>,
	lgirdwood@gmail.com
Subject: Re: [PATCH v7 5/9] ASoC: hdac_hdmi: Fix to wait for D3 before powering off codec
Date: Sat, 20 Feb 2016 00:56:40 +0900	[thread overview]
Message-ID: <20160219155640.GU18327@sirena.org.uk> (raw)
In-Reply-To: <1455725047-7303-6-git-send-email-subhransu.s.prusty@intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 298 bytes --]

On Wed, Feb 17, 2016 at 09:34:03PM +0530, Subhransu S. Prusty wrote:

> +		/* Wait till power state is set to D3 */
> +		timeout = jiffies + msecs_to_jiffies(1000);
> +		while(!snd_hdac_check_power_state(hdac, hdac->afg, AC_PWRST_D3)

Please follow the kernel coding style - space after the while.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2016-02-20 17:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-17 16:03 [PATCH v7 0/9] ASoC: hdac_hdmi: Update to HDMI driver Subhransu S. Prusty
2016-02-17 16:03 ` [PATCH v7 1/9] ASoC: hdac_hdmi: Fix possible memory leak in hw_params Subhransu S. Prusty
2016-02-20 17:15   ` Applied "ASoC: hdac_hdmi: Fix possible memory leak in hw_params" to the asoc tree Mark Brown
2016-02-17 16:04 ` [PATCH v7 2/9] ASoC: hdac_hdmi: Don't fail in dai startup to make userland happy Subhransu S. Prusty
2016-02-20 17:15   ` Applied "ASoC: hdac_hdmi: Don't fail in dai startup to make userland happy" to the asoc tree Mark Brown
2016-02-17 16:04 ` [PATCH v7 3/9] ASoC: hdac_hdmi: Fix to keep codec power active during enumeration Subhransu S. Prusty
2016-02-17 16:04 ` [PATCH v7 4/9] ASoC: hdac_hdmi: Fix to reconfigure registers in runtime resume Subhransu S. Prusty
2016-02-19 15:55   ` Mark Brown
2016-02-17 16:04 ` [PATCH v7 5/9] ASoC: hdac_hdmi: Fix to wait for D3 before powering off codec Subhransu S. Prusty
2016-02-19 15:56   ` Mark Brown [this message]
2016-02-17 16:04 ` [PATCH v7 6/9] ASoC: hdac_hdmi: Add PM support Subhransu S. Prusty
2016-02-17 16:04 ` [PATCH v7 7/9] ASoC: Intel: Skylake: Fix possible memory corruption in codec dai dma params Subhransu S. Prusty
2016-02-20 17:15   ` Applied "ASoC: Intel: Skylake: Fix possible memory corruption in codec dai dma params" to the asoc tree Mark Brown
2016-02-17 16:04 ` [PATCH v7 8/9] ASoC: Intel: Skylake: Add i915 enabling in skl probe Subhransu S. Prusty
2016-02-20 17:15   ` Applied "ASoC: Intel: Skylake: Add i915 enabling in skl probe" to the asoc tree Mark Brown
2016-02-17 16:04 ` [PATCH v7 9/9] ASoC: Intel: Skylake: Add HDMI FE and BE cpu dais Subhransu S. Prusty
2016-02-20 17:15   ` Applied "ASoC: Intel: Skylake: Add HDMI FE and BE cpu dais" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160219155640.GU18327@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=lgirdwood@gmail.com \
    --cc=patches.audio@intel.com \
    --cc=subhransu.s.prusty@intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).