From: Mark Brown <broonie@kernel.org>
To: John Lin <john.lin@realtek.com>
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, bardliao@realtek.com,
zhengsq@rock-chips.com, flove@realtek.com
Subject: Re: [PATCH] ASoC: rt5616: add kcontrol for headphone channel switch
Date: Wed, 2 Mar 2016 19:35:35 +0900 [thread overview]
Message-ID: <20160302103535.GH18327@sirena.org.uk> (raw)
In-Reply-To: <1456910320-6979-1-git-send-email-john.lin@realtek.com>
[-- Attachment #1.1: Type: text/plain, Size: 422 bytes --]
On Wed, Mar 02, 2016 at 05:18:40PM +0800, John Lin wrote:
> SOC_DOUBLE("HP Playback Switch", RT5616_HP_VOL,
> RT5616_L_MUTE_SFT, RT5616_R_MUTE_SFT, 1, 1),
> + SOC_DOUBLE("HP Channel Switch", RT5616_HP_VOL,
> + RT5616_VOL_L_SFT, RT5616_VOL_R_SFT, 1, 1),
What does "Channel Switch" mean? It looks like this is a mute control
in which case it shoiuld be HP Playback Switch or similar like other
mute controls.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-03-02 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 9:18 [PATCH] ASoC: rt5616: add kcontrol for headphone channel switch John Lin
2016-03-02 10:35 ` Mark Brown [this message]
2016-03-03 2:45 ` John Lin
2016-03-03 7:21 ` Shunqian Zheng
2016-03-05 3:51 ` Mark Brown
2016-03-07 2:35 ` John Lin
2016-03-07 2:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302103535.GH18327@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=flove@realtek.com \
--cc=john.lin@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).