From: Mark Brown <broonie@kernel.org>
To: John Hsu <KCHSU0@nuvoton.com>
Cc: alsa-devel@alsa-project.org, anatol.pomozov@gmail.com,
YHCHuang@nuvoton.com, lgirdwood@gmail.com, benzh@chromium.org,
CTLIN0@nuvoton.com, mhkuo@nuvoton.com, yong.zhi@intel.com
Subject: Re: [PATCH] ASoC: nau8825: fix interrupt fails and unstable after resume
Date: Tue, 15 Mar 2016 09:27:11 +0000 [thread overview]
Message-ID: <20160315092711.GH2566@sirena.org.uk> (raw)
In-Reply-To: <56E1105E.8010604@nuvoton.com>
[-- Attachment #1.1: Type: text/plain, Size: 924 bytes --]
On Thu, Mar 10, 2016 at 02:12:46PM +0800, John Hsu wrote:
> On 3/1/2016 11:26 AM, Mark Brown wrote:
> >On Mon, Feb 29, 2016 at 03:01:45AM +0800, John Hsu wrote:
> >>+static int nau8825_resume_setup(struct nau8825 *nau8825)
> >>+{
> >I'd expect to see this shared with initial power on?
> There is a little things different between resume and initiation.
> But I think the function could be reused.
Really? Bear in mind the device might have lost power over suspend...
> >> regcache_cache_only(nau8825->regmap, false);
> >>- regcache_sync(nau8825->regmap);
> >>- enable_irq(client->irq);
> >>+ enable_irq(nau8825->irq);
> >We're removing the register cache sync here but I don't see us adding it
> >anywhere else.
> A part of suspend and resume action moves to set bias function,
> nau8825_set_bias_level.
> We make register cache dirty in bias off; and make register cache sync after
> resume in bias standby.
OK.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-03-15 9:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-28 19:01 [PATCH] ASoC: nau8825: fix interrupt fails and unstable after resume John Hsu
2016-02-28 19:47 ` [PATCH v2] ASoC: nau8825: reduce stanby power consumption John Hsu
2016-03-05 4:10 ` Mark Brown
2016-03-01 3:26 ` [PATCH] ASoC: nau8825: fix interrupt fails and unstable after resume Mark Brown
2016-03-10 6:12 ` John Hsu
2016-03-15 7:53 ` John Hsu
2016-03-15 9:27 ` Mark Brown
2016-03-15 9:27 ` Mark Brown [this message]
2016-03-16 3:45 ` John Hsu
-- strict thread matches above, loose matches on Subject: below --
2016-03-22 3:57 John Hsu
2016-03-26 0:08 ` Ben Zhang
2016-03-30 9:35 ` John Hsu
2016-01-12 1:09 John Hsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160315092711.GH2566@sirena.org.uk \
--to=broonie@kernel.org \
--cc=CTLIN0@nuvoton.com \
--cc=KCHSU0@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=anatol.pomozov@gmail.com \
--cc=benzh@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=mhkuo@nuvoton.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).