alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Zidan Wang <zidan.wang@freescale.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org, Xiubo.Lee@gmail.com
Subject: Re: [PATCH v5] ASoC: imx-wm8958: add imx-wm8958 machine driver
Date: Tue, 15 Mar 2016 10:44:34 -0700	[thread overview]
Message-ID: <20160315174433.GA5911@Asurada-Nvidia> (raw)
In-Reply-To: <011ce146f58a54dda8d8f6ef1c494f92550443bc.1457510037.git.zidan.wang@freescale.com>

On Wed, Mar 09, 2016 at 04:18:19PM +0800, Zidan Wang wrote:
> This is an initial imx-wm8958 device-tree-only machine driver.
> The sound card driver support three dai link, HIFI, VOICE and BT.
> We can configure the cpu dai from device tree, if present it
> will create corresponding sound card subdevice. So at least
> one cpu dai phandle should be set from device tree.
> 
> Signed-off-by: Zidan Wang <zidan.wang@freescale.com>
> ---
> v4->v5: support set dai link name and stream name from device tree.

> +++ b/sound/soc/fsl/imx-wm8958.c
[...]
> +#include <linux/of_gpio.h>
> +#include <linux/gpio.h>
[...]

I don't think you need these two any more.

Otherwise,
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

      reply	other threads:[~2016-03-15 17:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09  8:18 [PATCH v5] ASoC: imx-wm8958: add imx-wm8958 machine driver Zidan Wang
2016-03-15 17:44 ` Nicolin Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160315174433.GA5911@Asurada-Nvidia \
    --to=nicoleotsuka@gmail.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=zidan.wang@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).