alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: Piotr Stankiewicz <piotrs@opensource.wolfsonmicro.com>,
	alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: dpcm: prevent error for paths including static links
Date: Wed, 30 Mar 2016 09:58:12 +0100	[thread overview]
Message-ID: <20160330085812.GE31814@localhost.localdomain> (raw)
In-Reply-To: <20160329212224.GM2350@sirena.org.uk>

On Tue, Mar 29, 2016 at 02:22:24PM -0700, Mark Brown wrote:
> On Tue, Mar 15, 2016 at 03:34:49PM +0000, Piotr Stankiewicz wrote:
> 
> > This happens when setting up, e.g. a route starting with a dynamic
> > DAI, which passes through a static DAI (say, "Some FE" -> "Some BE"
> > -> "Codec to Modem link"). All DAPM widgets involved in that path will
> 
> Is this not just a normal CODEC connected to a back end on a DPCM
> system?  What are a "dynamic DAI" and "static DAI"?  Your changelog is
> very unclear, I really can't tell from your changelog what this is
> aiming to do or how it proposes to do it.

The issue is basically if you have a path with a DPCM DAI at the
front, but then a regular CODEC to CODEC DAI link later in the
path. Say for example a CODEC attached to a CPU that uses DPCM
but then the path goes through a CODEC to CODEC link to a speaker
AMP after the CODEC.

> 
> I'm also concerned that nobody else seems to be seeing this, that's a
> bit of a warning sign that you might be misusing things here.  Your
> mention of a "Codec to Modem link" sounds like you might be trying to
> use DPCM for off-SoC components somehow which is just not something
> that's expected to work.
> 
> At a minimum this needs a much better changelog.

Piotr is on holiday this week but should be back start of next
week, so should be able to respin the patch then. For what its
worth though I have seen this warning on other systems from the
one he is working on as well.

Thanks,
Charles

  reply	other threads:[~2016-03-30  8:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15 15:34 [PATCH] ASoC: dpcm: prevent error for paths including static links Piotr Stankiewicz
2016-03-29 21:22 ` Mark Brown
2016-03-30  8:58   ` Charles Keepax [this message]
2016-03-30 16:36     ` Mark Brown
2016-03-30 17:13       ` Charles Keepax
2016-03-30 17:27         ` Mark Brown
2016-03-31  8:17           ` Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160330085812.GE31814@localhost.localdomain \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=piotrs@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).