From: Mark Brown <broonie@kernel.org>
To: Ben Zhang <benzh@chromium.org>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
Anatol Pomozov <anatol.pomozov@gmail.com>,
John Hsu <KCHSU0@nuvoton.com>,
Liam Girdwood <lgirdwood@gmail.com>,
YHCHuang@nuvoton.com, CTLIN0@nuvoton.com, mhkuo@nuvoton.com,
yong.zhi@intel.com
Subject: Re: [PATCH] ASoC: nau8825: assign DAC Ch to match headset L/R
Date: Wed, 30 Mar 2016 16:32:31 -0700 [thread overview]
Message-ID: <20160330233231.GY2350@sirena.org.uk> (raw)
In-Reply-To: <CAOV7ByLnc63QJyJhxLoCuD590bcg_mvhcb2cPK=zd=QYy__maw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 731 bytes --]
On Wed, Mar 30, 2016 at 03:55:49PM -0700, Ben Zhang wrote:
> The channel selection is already exposed by DAPM widget "DACL Mux" and
> "DACR Mux". The issue is that hardware default register values after
> reset have the channels reversed as R/L. This patch is for
And nobody managed to notice that this might be a problem before the
part was released and relabel things? Yay.
> initializing to the normal L/R channels after boot. The default should
> be normal L/R from userspace point of view. If userspace wants some
> other settings later, it can set the muxes to get R/L, L/L, or R/R.
This is yet another case where clearer changelogs would really help.
It is a lot easier to review changes if they are clearly described.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-03-30 23:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 6:57 [PATCH] ASoC: nau8825: assign DAC Ch to match headset L/R John Hsu
2016-03-30 17:39 ` Mark Brown
2016-03-30 22:55 ` Ben Zhang
2016-03-30 23:32 ` Mark Brown [this message]
2016-03-31 17:20 ` Applied "ASoC: nau8825: assign DAC Ch to match headset L/R" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330233231.GY2350@sirena.org.uk \
--to=broonie@kernel.org \
--cc=CTLIN0@nuvoton.com \
--cc=KCHSU0@nuvoton.com \
--cc=YHCHuang@nuvoton.com \
--cc=alsa-devel@alsa-project.org \
--cc=anatol.pomozov@gmail.com \
--cc=benzh@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=mhkuo@nuvoton.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).