From: Mark Brown <broonie@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
anish kumar <yesanishhere@gmail.com>
Subject: Re: [PATCH] ASoC: Add max98371 codec driver
Date: Sun, 10 Apr 2016 19:04:21 +0100 [thread overview]
Message-ID: <20160410180421.GA18319@sirena.org.uk> (raw)
In-Reply-To: <570720D5.9060901@metafoo.de>
[-- Attachment #1.1: Type: text/plain, Size: 582 bytes --]
On Fri, Apr 08, 2016 at 05:09:09AM +0200, Lars-Peter Clausen wrote:
> > + ret = regmap_read(max98371->regmap, MAX98371_VERSION, ®);
> > + if (ret < 0) {
> > + dev_info(&i2c->dev, "device error %d\n", ret);
> > + return ret;
> > + }
> > + dev_info(&i2c->dev, "device version %x\n", reg);
> Drop this, it is just noise in the boot log.
It's generally OK to print information about the actual hardware found
in the system, it can be a helpful diagnostic. Getting all this stuff
into sysfs files would be even better but that doesn't seem to be how we
do things at the minute.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-04-10 18:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 6:53 [PATCH] ASoC: Add max98371 codec driver anish kumar
2016-03-28 19:13 ` Mark Brown
2016-04-07 19:34 ` anish kumar
2016-04-08 3:09 ` Lars-Peter Clausen
2016-04-08 20:04 ` anish kumar
2016-04-10 18:04 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-04-27 22:39 anish kumar
2016-04-13 20:20 anish kumar
2016-04-18 16:47 ` Mark Brown
2016-04-18 20:20 ` anish kumar
2016-04-19 9:46 ` Mark Brown
2016-04-20 18:14 ` anish kumar
2016-04-22 15:31 ` Mark Brown
2016-04-26 18:16 ` anish kumar
2016-04-27 16:42 ` Mark Brown
2016-03-21 1:59 anish kumar
2016-03-21 14:56 ` Mark Brown
2016-03-21 15:29 ` Micka
2016-03-21 15:56 ` Mark Brown
2016-03-21 16:41 ` Micka
2016-03-21 17:05 ` Mark Brown
2016-03-23 12:45 ` Micka
2016-03-23 16:23 ` Amish Kumar
2016-03-24 10:49 ` Micka
2016-03-24 11:05 ` Mark Brown
2016-03-24 11:19 ` Micka
2016-03-24 11:21 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160410180421.GA18319@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=yesanishhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).