From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
patches@opensource.wolfsonmicro.com, lgirdwood@gmail.com,
broonie@kernel.org
Subject: Re: [PATCH v3 2/4] ALSA: compress: Add function to indicate the stream has gone bad
Date: Mon, 11 Apr 2016 16:13:41 +0100 [thread overview]
Message-ID: <20160411151341.GP31814@localhost.localdomain> (raw)
In-Reply-To: <s5hpotw2ooc.wl-tiwai@suse.de>
On Mon, Apr 11, 2016 at 04:41:23PM +0200, Takashi Iwai wrote:
> On Mon, 11 Apr 2016 16:27:33 +0200,
> Charles Keepax wrote:
> > + switch (stream->runtime->state) {
> > + case SNDRV_PCM_STATE_OPEN:
> > + case SNDRV_PCM_STATE_XRUN:
> > + return -EBADFD;
>
> One question is whether we want a dedicated error code for XRUN or
> such a DSP error. On PCM, for example, we return -EPIPE traditionally
> for XRUN state. This is a clear indicator for user what to do at
> next.
>
> Other than that, the patch series looks good to me.
I think it probably makes sense to copy what the PCM framework
does here, I will respin and use EPIPE.
Thanks,
Charles
next prev parent reply other threads:[~2016-04-11 15:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 14:27 [PATCH v3 0/4] Propagate errors out from compressed streams Charles Keepax
2016-04-11 14:27 ` [PATCH v3 1/4] ALSA: compress: Replace complex if statement with switch Charles Keepax
2016-04-11 14:27 ` [PATCH v3 2/4] ALSA: compress: Add function to indicate the stream has gone bad Charles Keepax
2016-04-11 14:41 ` Takashi Iwai
2016-04-11 15:13 ` Charles Keepax [this message]
2016-04-11 14:27 ` [PATCH v3 3/4] ASoC: wm_adsp: Use new snd_compr_stop_error to signal stream failure Charles Keepax
2016-06-13 15:50 ` Applied "ASoC: wm_adsp: Use new snd_compr_stop_error to signal stream failure" to the asoc tree Mark Brown
2016-04-11 14:27 ` [PATCH v3 4/4] ASoC: compress: Pass error out of soc_compr_pointer Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411151341.GP31814@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).