alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Alan Horstmann <gineera@aspect135.co.uk>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH] aplay: fix lurking capture file overwrite bug
Date: Fri, 15 Apr 2016 21:25:37 +0100	[thread overview]
Message-ID: <201604152125.37337.gineera@aspect135.co.uk> (raw)
In-Reply-To: <20160414043246.GB16174@spacedout.fries.net>

On Thursday 14 April 2016 05:32, David Fries wrote:
> If -d was given to arecord while commit
> 8aa13eec80eac312e4b99423909387660fb99b8f (now reverted) was in effect,
> the last read would be shorter than the chunk size, but pcm_read would
> read and return the chunk size, the samples were discarded, and
> capture() continued in a loop because count never reached 0.  arecord
> opens a new file each loop iteration, if arecord is dynamically naming
> files, --use-strftime option or beyond the wave 2GB limit, this will
> generate a series of header only wave files. 

<snip>

> Debian has the effectively broken pcm_read,

It is fortunate for me that you mentioned those details as I have just been 
bitten by exactly that, using arecord whilst tracking down a Portaudio issue 
in Debian Jessie!  I was gearing up to report the bug, assuming it was in the 
capture system.

It seems a pity that Debian Jessie stable doesn't have a backport of the 
fix/revert.

Now back to tracing the original issue...

Regards

Alan

  parent reply	other threads:[~2016-04-15 20:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-14  4:32 [PATCH] aplay: fix lurking capture file overwrite bug David Fries
2016-04-14 12:36 ` Takashi Iwai
2016-04-15 20:25 ` Alan Horstmann [this message]
2016-04-18  3:34   ` David Fries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201604152125.37337.gineera@aspect135.co.uk \
    --to=gineera@aspect135.co.uk \
    --cc=alsa-devel@alsa-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).