From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, patches.audio@intel.com,
liam.r.girdwood@linux.intel.com, broonie@kernel.org,
Shreyas NC <shreyas.nc@intel.com>,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH v3 1/3] conf: topology: Add Skylake i2s conf
Date: Thu, 21 Apr 2016 16:24:04 +0530 [thread overview]
Message-ID: <20160421105403.GO2274@localhost> (raw)
In-Reply-To: <s5hwpnrxw7y.wl-tiwai@suse.de>
On Thu, Apr 21, 2016 at 09:22:09AM +0200, Takashi Iwai wrote:
> > +++ b/src/conf/topology/sklrt286/Makefile.am
> > @@ -0,0 +1,11 @@
> > +alsaconfigdir = @ALSA_CONFIG_DIR@
> > +SUBDIRS = data
> > +sklrt286dir = $(alsaconfigdir)/topology/sklrt286
> > +sklrt286_DATA = skl_i2s.conf
> > +EXTRA_DIST = sklrt286_DATA
>
> Isn't it $(sklrt286_DATA)?
Yes, will fix
> > +install-data-hook:
> > + cp -p media0_in-cpr-0.bin media0_in-mi.bin media0_out-mo.bin media0_out-cpr-6.bin codec0_out-mo.bin codec0_out-cpr-4.bin codec1_out-mo.bin codec1_out-cpr-5.bin codec0_in-cpr-1.bin codec0_in-mi.bin dmic01_hifi_in-cpr-3.bin dmic01_hifi_in-mi.bin hdmi1_pt_out-cpr-7.bin hdmi1_pt_out-cpr-8.bin hdmi2_pt_out-cpr-9.bin hdmi2_pt_out-cpr-10.bin hdmi3_pt_out-cpr-11.bin hdmi3_pt_out-cpr-12.bin $(sklrt286dir)
>
> I guess these bin files aren't present or generated in this patch?
> This would break bisection.
Okay, will move this to second one
--
~Vinod
next prev parent reply other threads:[~2016-04-21 10:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 6:27 [PATCH v3 0/3] conf: topology: Add the conf for SKL-rt286 Vinod Koul
2016-04-21 6:27 ` [PATCH v3 1/3] conf: topology: Add Skylake i2s conf Vinod Koul
2016-04-21 7:22 ` Takashi Iwai
2016-04-21 10:54 ` Vinod Koul [this message]
2016-04-21 6:27 ` [PATCH v3 2/3] Add u8 in type_compat.h Vinod Koul
2016-04-21 6:27 ` [PATCH v3 3/3] conf: topology: Generate Private data binary blobs Vinod Koul
2016-04-21 7:23 ` Takashi Iwai
2016-04-21 10:56 ` Vinod Koul
2016-04-21 11:00 ` Takashi Iwai
2016-04-22 3:16 ` Vinod Koul
2016-04-21 7:19 ` [PATCH v3 0/3] conf: topology: Add the conf for SKL-rt286 Takashi Iwai
2016-04-21 10:53 ` Vinod Koul
2016-04-21 11:02 ` Takashi Iwai
2016-04-22 3:14 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421105403.GO2274@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=shreyas.nc@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).