From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org, Shreyas NC <shreyas.nc@intel.com>
Subject: Re: [PATCH v2 2/2] ASoC: Intel: Skylake: Add DSP firmware manifest parsing
Date: Fri, 22 Apr 2016 08:43:51 +0530 [thread overview]
Message-ID: <20160422031350.GQ2274@localhost> (raw)
In-Reply-To: <20160421160713.GV3217@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 654 bytes --]
On Thu, Apr 21, 2016 at 05:07:13PM +0100, Mark Brown wrote:
> On Thu, Apr 21, 2016 at 11:45:23AM +0530, Vinod Koul wrote:
>
> > + num_entry = adsp_hdr->num_module_entries;
> > +
> > + tbl = devm_kzalloc(ctx->dev,
> > + num_entry * sizeof(struct uuid_tbl), GFP_KERNEL);
> > +
> > + if (!tbl)
> > + return -ENOMEM;
>
> I'm still not seeing any bounds checking to make sure we don't read
> beyond the end of the firmware file.
Since we are using adsp_hdr->num_module_entrie for parsing technically we
should not go beyond.
But yes if the file goes bad then we might have an issue, we will add check
for that
Thanks
--
~Vinod
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2016-04-22 3:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 6:15 [PATCH v2 0/2] ASoC: Intel: Skylake: Add support for firmware manifest Vinod Koul
2016-04-21 6:15 ` [PATCH v2 1/2] ASoC: Intel: Skylake: Use UUID in binary format Vinod Koul
2016-04-21 16:11 ` Applied "ASoC: Intel: Skylake: Use UUID in binary format" to the asoc tree Mark Brown
2016-04-21 6:15 ` [PATCH v2 2/2] ASoC: Intel: Skylake: Add DSP firmware manifest parsing Vinod Koul
2016-04-21 16:07 ` Mark Brown
2016-04-22 3:13 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422031350.GQ2274@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=shreyas.nc@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox