alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
	alsa-devel@alsa-project.org, broonie@kernel.org,
	Shreyas NC <shreyas.nc@intel.com>
Subject: Re: [PATCH v3 3/3] conf: topology: Generate Private data binary blobs
Date: Fri, 22 Apr 2016 08:46:16 +0530	[thread overview]
Message-ID: <20160422031616.GS2274@localhost> (raw)
In-Reply-To: <s5hvb3bdy5x.wl-tiwai@suse.de>

On Thu, Apr 21, 2016 at 01:00:26PM +0200, Takashi Iwai wrote:
> On Thu, 21 Apr 2016 12:56:54 +0200,
> Vinod Koul wrote:
> > 
> > On Thu, Apr 21, 2016 at 09:23:25AM +0200, Takashi Iwai wrote:
> > > On Thu, 21 Apr 2016 08:27:38 +0200,
> > > Vinod Koul wrote:
> > > > 
> > > > From: Shreyas NC <shreyas.nc@intel.com>
> > > > 
> > > > The DSP modules need private data and that is provided as binary
> > > > blob. These blobs are compiled from C structures which specify module
> > > > configuration.
> > > > 
> > > > Signed-off-by: Shreyas NC <shreyas.nc@intel.com>
> > > > Signed-off-by: Vinod Koul <vinod.koul@intel.com>
> > > 
> > > What if this program is executed on big endian system?
> > 
> > So we made the data structure m,emebers as __lexx shouldn't that take care
> > of this, or we can say, we don't support BE systems.
> > 
> > Am not sure if someone running BE system will be intrested in Intel aDSP :D
> 
> It's not about whether it runs on a BE system.  The most likely
> problem is about the package build.
> 
> The firmware sub-package is usually handled as a noarch one that is
> used commonly among all architectures.  If you generate a different
> data per architecture and write to the same file, it results in the
> inconsistent package, since the firmware generated by a BE host may be
> used for LE machine.
> 
> So, this needs a bit more consideration.  If we don't provide the
> firmware binary but only rely on the file creation at build time, it
> won't get the complete set depending on the running machine.
> 
> Maybe we should add the binary files in addition to the f/w generation
> code in case anyone needs to modify the data.

Yes anyway based on other discussion we will add precompiled files as well
to this, so default binary data is present. And we should generate only if
someone modifies, will modify this

Thanks
-- 
~Vinod

  reply	other threads:[~2016-04-22  3:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-21  6:27 [PATCH v3 0/3] conf: topology: Add the conf for SKL-rt286 Vinod Koul
2016-04-21  6:27 ` [PATCH v3 1/3] conf: topology: Add Skylake i2s conf Vinod Koul
2016-04-21  7:22   ` Takashi Iwai
2016-04-21 10:54     ` Vinod Koul
2016-04-21  6:27 ` [PATCH v3 2/3] Add u8 in type_compat.h Vinod Koul
2016-04-21  6:27 ` [PATCH v3 3/3] conf: topology: Generate Private data binary blobs Vinod Koul
2016-04-21  7:23   ` Takashi Iwai
2016-04-21 10:56     ` Vinod Koul
2016-04-21 11:00       ` Takashi Iwai
2016-04-22  3:16         ` Vinod Koul [this message]
2016-04-21  7:19 ` [PATCH v3 0/3] conf: topology: Add the conf for SKL-rt286 Takashi Iwai
2016-04-21 10:53   ` Vinod Koul
2016-04-21 11:02     ` Takashi Iwai
2016-04-22  3:14       ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160422031616.GS2274@localhost \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=shreyas.nc@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).