From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH] ASoC: omap-pcm: Initialize DMA configuration Date: Tue, 26 Apr 2016 16:01:56 +0300 Message-ID: <20160426130156.GA15388@bitmer.com> References: <1461600607-19582-1-git-send-email-Linux.HWI@garmin.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from bitmer.com (bitmer.com [213.157.87.50]) by alsa0.perex.cz (Postfix) with ESMTP id 965412608B3 for ; Tue, 26 Apr 2016 15:03:12 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1461600607-19582-1-git-send-email-Linux.HWI@garmin.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "J.D. Schroeder" Cc: alsa-devel@alsa-project.org, "J.D. Schroeder" , lgirdwood@gmail.com, linux-kernel@vger.kernel.org, tiwai@suse.com, peter.ujfalusi@ti.com, Jim Lodes , broonie@kernel.org, linux-omap@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Mon, Apr 25, 2016 at 11:10:07AM -0500, J.D. Schroeder wrote: > From: Jim Lodes > > Initialize the dma_slave_config for PCM DMA transfers, > instead of leaving it uninitialized. Keeps previous data on > the stack from giving us invalid values in uninitialized > members of the config structure. > > Signed-off-by: Jim Lodes > Signed-off-by: J.D. Schroeder > --- > sound/soc/omap/omap-pcm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c > index 99381a2..a84f677 100644 > --- a/sound/soc/omap/omap-pcm.c > +++ b/sound/soc/omap/omap-pcm.c > @@ -82,6 +82,8 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream, > struct dma_chan *chan; > int err = 0; > > + memset(&config, 0x00, sizeof(config)); Based on a894bd7fb539 ("ASoC: generic-dmaengine-pcm: Clear slave_config memory") Acked-by: Jarkko Nikula Reviewed-by: Jarkko Nikula