From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
alsa-devel@alsa-project.org, broonie@kernel.org,
shawnguo@kernel.org, brain@jikos.cz
Subject: Re: [PATCH v3 1/2] ASoC: fsl_sai: Introduce a compatible string for MX6UL
Date: Wed, 4 May 2016 16:10:43 -0700 [thread overview]
Message-ID: <20160504231042.GA17009@Asurada-Nvidia> (raw)
In-Reply-To: <1462401239-995-1-git-send-email-festevam@gmail.com>
On Wed, May 04, 2016 at 07:33:58PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> MX6UL may need to configure the General Purpose Register 1 (GPR1), so
> it is better to add a new compatible string to differentiate.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thank you
Nicolin
> ---
> Changes since v2:
> - Add binding doc entry for mx6ul (Nicolin)
>
> Documentation/devicetree/bindings/sound/fsl-sai.txt | 4 ++--
> sound/soc/fsl/fsl_sai.c | 4 +++-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl-sai.txt b/Documentation/devicetree/bindings/sound/fsl-sai.txt
> index 044e5d7..777b941 100644
> --- a/Documentation/devicetree/bindings/sound/fsl-sai.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl-sai.txt
> @@ -7,8 +7,8 @@ codec/DSP interfaces.
>
> Required properties:
>
> - - compatible : Compatible list, contains "fsl,vf610-sai" or
> - "fsl,imx6sx-sai".
> + - compatible : Compatible list, contains "fsl,vf610-sai",
> + "fsl,imx6sx-sai" or "fsl,imx6ul-sai"
>
> - reg : Offset and length of the register set for the device.
>
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index 0754df7..d8b673f 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -797,7 +797,8 @@ static int fsl_sai_probe(struct platform_device *pdev)
>
> sai->pdev = pdev;
>
> - if (of_device_is_compatible(pdev->dev.of_node, "fsl,imx6sx-sai"))
> + if (of_device_is_compatible(pdev->dev.of_node, "fsl,imx6sx-sai") ||
> + of_device_is_compatible(pdev->dev.of_node, "fsl,imx6ul-sai"))
> sai->sai_on_imx = true;
>
> sai->is_lsb_first = of_property_read_bool(np, "lsb-first");
> @@ -898,6 +899,7 @@ static int fsl_sai_probe(struct platform_device *pdev)
> static const struct of_device_id fsl_sai_ids[] = {
> { .compatible = "fsl,vf610-sai", },
> { .compatible = "fsl,imx6sx-sai", },
> + { .compatible = "fsl,imx6ul-sai", },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, fsl_sai_ids);
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-05-04 23:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 22:33 [PATCH v3 1/2] ASoC: fsl_sai: Introduce a compatible string for MX6UL Fabio Estevam
2016-05-04 22:33 ` [PATCH v3 2/2] ASoC: fsl_sai: Allow setting the SAI MCLK direction Fabio Estevam
2016-05-04 23:11 ` Nicolin Chen
2016-05-05 15:56 ` Applied "ASoC: fsl_sai: Allow setting the SAI MCLK direction" to the asoc tree Mark Brown
2016-05-04 23:10 ` Nicolin Chen [this message]
2016-05-05 15:56 ` Applied "ASoC: fsl_sai: Introduce a compatible string for MX6UL" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160504231042.GA17009@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=brain@jikos.cz \
--cc=broonie@kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).