Re: [PATCH 1/2] ASoC: nau8825: non-clock jack detection for power saving at standby

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1411 bytes --]

On Fri, May 06, 2016 at 03:41:42PM +0800, John Hsu wrote:
> On 5/5/2016 12:39 AM, Mark Brown wrote:
> > On Tue, May 03, 2016 at 05:20:00PM +0800, John Hsu wrote:

> > > For clear expression, we should print error message and return error to
> > > caller. Is it right?

> > It'd be better to just accept the configuration but what you suggest is
> > less bad than just completely ignoring the problem.

> The codec needs internal clock for interruption at auto mode. Therefor, the
> system clock will go back to internal clock after playback to end. But we
> don't want this happened when jack is ejected already. We expected no in-
> ternal clock when no headset connected; but the system will turn on it when
> playback finish. For the reason, the driver adds error check to avoid this
> situation happened.

I'm not sure I fully follow the above explanation.  I appreciate that
power consumption is not going to be optimal when the clock is provided
and the chip is idle but does it actually stop anything working?

> > This does not address the issue at all.  The interrupt is optional, it
> > may not have been wired up and the probe function handles that case
> > gracefully.

> The ejection interruption will turn on when resume for the issue. Let the
> probe function to handle it.

I don't see how the probe function can handle the fact that the resume
function is unconditionally calling enable_irq()?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]